Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use common Pharmaverse workflows #39

Merged
merged 7 commits into from
Jan 29, 2024
Merged

Conversation

cicdguy
Copy link
Collaborator

@cicdguy cicdguy commented Jan 23, 2024

Use common Pharmaverse workflows.

@cicdguy cicdguy self-assigned this Jan 23, 2024
@ddsjoberg
Copy link
Collaborator

ddsjoberg commented Jan 23, 2024

@cicdguy some questions:

  1. some of the workflows fail to install htmlwidgets from GH. Is installing from GH not allowed here?
  2. The Documentation workflow didn't trigger on the PR. It looks like it will trigger when it's merged to main? My previous workflow for pkgdown workflow would build the website for PRs, but wouldn't push to gh-pages until it was on main. Is that an option here? This helps us find issues in the pkgdown site before the PR is merged (most commonly, a missing exported function from the reference page).

Copy link

github-actions bot commented Jan 24, 2024

Code Coverage

Package Line Rate Health
admiraldiscovery 25%
Summary 25% (41 / 162)

@ddsjoberg
Copy link
Collaborator

@cicdguy @dgrassellyb thank you for adding the workflows!

There is one that is still failing. I don't think it's related to the anything in the repo. Is the issue transitory or a known issue with the workflows? Thanks!

@cicdguy
Copy link
Collaborator Author

cicdguy commented Jan 29, 2024

@cicdguy @dgrassellyb thank you for adding the workflows!

There is one that is still failing. I don't think it's related to the anything in the repo. Is the issue transitory or a known issue with the workflows? Thanks!

I think I can fix that one. Hang on.

Copy link
Collaborator

@ddsjoberg ddsjoberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!!! Thanks for bringing the repo to the modern era on CI/CD!

@ddsjoberg ddsjoberg merged commit 21c8006 into main Jan 29, 2024
17 checks passed
@ddsjoberg ddsjoberg deleted the fix/use-common-workflows branch January 29, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants