-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #35 moved presentation archive to gt #40
Conversation
@ddsjoberg I think I've successfully moved to using Also I guess I haven't looked at using icons yet but can do that later. |
Unit Tests Summary1 files 1 suites 25s ⏱️ Results for commit a68cdb8. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Additional test case details
Results for commit b2dcb14 ♻️ This comment has been updated with latest results. |
hey hey @manciniedoardo ! thanks for the PR, the table looks great! I see that you made the presentation history a data set saved with the package. If we go that route, you'll need to add data documentation to Since there are only 10 rows in the data frame, I don't think we need to make it an interactive table. If you remove the interactivity, the column widths will be as you've specified. Thanks! |
…se/admiraldiscovery into 35_presentation_archive_glowup
Looks almost perfect! I see the roxygen2 comments for the data set docs, but it looks like you'll need to re-document and push to get the Rd file. There is also a small typo in the data set documentation "fo" instead of "of" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Closes #35