Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #11 : vs_metabolic test data draft created #17

Closed
wants to merge 12 commits into from

Adding dm_metabolic files to wd (#11)

479f7ae
Select commit
Loading
Failed to load commit list.
Closed

Closes #11 : vs_metabolic test data draft created #17

Adding dm_metabolic files to wd (#11)
479f7ae
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed Started 2024-08-06 09:26:28 ago

11 / 14 tasks completed

3 tasks still to be completed

Details

Required Tasks

Task Status
Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update) Completed
Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files Completed
Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide Completed
If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance? Completed
Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family. Completed
Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately Completed
Address any updates needed for vignettes and/or templates Completed
Update NEWS.md under the header # admiral<ext> (development version) if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers) Completed
Build site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the Reference page. Completed
Address or fix all lintr warnings and errors - lintr::lint_package() Completed
Run R CMD check locally and address all errors and warnings - devtools::check() Incomplete
Link the issue in the Development Section on the right hand side. Completed
Address all merge conflicts and resolve appropriately Incomplete
Pat yourself on the back for a job well done! Much love to your accomplishment! Incomplete
merge main into your feature branch Incomplete
resolve any conflicts Incomplete
update your script to use dm_metabolic Incomplete
check the failing code style and lintr checks to see if you can fix them (happy to support if not) Incomplete