Skip to content

Commit

Permalink
Merge pull request #265 from pharmaverse/233_iRECIST_vignette_main
Browse files Browse the repository at this point in the history
Request to close 233 - iRecist vignette initial draft
  • Loading branch information
bundfussr authored Dec 13, 2023
2 parents 088e3b8 + 2719463 commit 1edb886
Show file tree
Hide file tree
Showing 5 changed files with 899 additions and 7 deletions.
4 changes: 1 addition & 3 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
Please add "Closes #<issue number>" to the title of the pull request. Then the
issue is closed automatically once it is merged to `main`.

Thank you for your Pull Request! We have developed this task checklist from the
[Development Process
Guide](https://pharmaverse.github.io/admiral/CONTRIBUTING.html#detailed-development-process)
Expand All @@ -13,6 +10,7 @@ or check off that it is not relevant to your Pull Request. This checklist is
part of the Github Action workflows and the Pull Request will not be merged into
the `main` branch until you have checked off each task.

- [ ] Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update). Then the issue is closed automatically once it is merged to `main`.
- [ ] Code is formatted according to the [tidyverse style guide](https://style.tidyverse.org/). Run `styler::style_file()` to style R and Rmd files
- [ ] Updated relevant unit tests or have written new unit tests - See [Unit Test Guide](https://pharmaverse.github.io/admiraldev/articles/unit_test_guidance.html#writing-unit-tests-in-admiral)
- [ ] If you removed/replaced any function and/or function parameters, did you fully follow the [deprecation guidance](https://pharmaverse.github.io/admiraldev/articles/programming_strategy.html#deprecation)?
Expand Down
10 changes: 6 additions & 4 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
# admiralonco (development version)

## Various

- Website now has button/links to Slack channel and GitHub Issues. (#262)

## Documentation

- New vignette "Creating ADRS with iRECIST endpoints". (#233)

- All vignettes and templates were updated to be in line with the changes in
`{admiral}` (see [Breaking
Changes](https://pharmaverse.github.io/admiral/news/index.html#breaking-changes-1-0-0)
Expand All @@ -23,6 +21,10 @@ won't be deprecated in the near future. (#256)
- The function `call_aval_fun()`, which was deprecated in admiralonco 0.4.0,
has been removed. (#256)

## Various

- Website now has button/links to Slack channel and GitHub Issues. (#262)

# admiralonco 0.5.0

## New Features
Expand Down
2 changes: 2 additions & 0 deletions _pkgdown.yml
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,8 @@ navbar:
href: articles/adrs_basic.html
- text: Creating ADRS (Including Non-standard Endpoints)
href: articles/adrs.html
- text: Creating ADRS with iRECIST endpoints
href: articles/irecist.html
- text: Creating ADTTE
href: articles/adtte.html
- text: Creating ADTR
Expand Down
6 changes: 6 additions & 0 deletions inst/WORDLIST
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,12 @@ CDISC
CRF
GlaxoSmithKline
Hoffmann
IBCP
ICBCP
ILSTA
IMDIS
IMWG
IOVRB
IRF
LLC
Myeloma
Expand All @@ -29,6 +34,7 @@ durations
evaluable
fmt
funder
iCPD
iRECIST
myeloma
pharmaverse
Expand Down
Loading

0 comments on commit 1edb886

Please sign in to comment.