Skip to content

Commit

Permalink
#256 admiral_updates: fix links
Browse files Browse the repository at this point in the history
  • Loading branch information
bundfussr committed Dec 12, 2023
1 parent e8b5b7f commit 2c92305
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 3 deletions.
12 changes: 10 additions & 2 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,17 @@
Please add "Closes #<issue number>" to the title of the pull request. Then the
issue is closed automatically once it is merged to `main`.

Thank you for your Pull Request! We have developed this task checklist from the [Development Process Guide](https://pharmaverse.github.io/admiraldev/articles/development_process.html) to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Thank you for your Pull Request! We have developed this task checklist from the
[Development Process
Guide](https://pharmaverse.github.io/admiral/CONTRIBUTING.html#detailed-development-process)
to help with the final steps of the process. Completing the below tasks helps to
ensure our reviewers can maximize their time on your code as well as making sure
the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the `devel` branch until you have checked off each task.
Please check off each taskbox as an acknowledgment that you completed the task
or check off that it is not relevant to your Pull Request. This checklist is
part of the Github Action workflows and the Pull Request will not be merged into
the `main` branch until you have checked off each task.

- [ ] Code is formatted according to the [tidyverse style guide](https://style.tidyverse.org/). Run `styler::style_file()` to style R and Rmd files
- [ ] Updated relevant unit tests or have written new unit tests - See [Unit Test Guide](https://pharmaverse.github.io/admiraldev/articles/unit_test_guidance.html#writing-unit-tests-in-admiral)
Expand Down
2 changes: 1 addition & 1 deletion vignettes/adtr.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ Some of the data frames needed may be `ADSL`, `ADRS` ,`RS`, `TU`, `TR`, `SUPPTU`
For example purposes, the SDTM and ADaM datasets (based on CDISC Pilot test
data)---which are included in `{pharmaversesdtm}` and `{pharmaverseadam}`---are
used. Also, see [Handling of Missing
Values](https://pharmaverse.github.io/admiral/cran-release/articles/admiral.html#handling-of-missing-values)
Values](https://pharmaverse.github.io/admiral/articles/admiral.html#handling-of-missing-values)
explains why we need to use the `convert_blanks_to_na()` function.

On the `TR` domain we filter on where tumor assessment short name `TRTESTCD` is
Expand Down

0 comments on commit 2c92305

Please sign in to comment.