Merge pull request #250 from pharmaverse/245_fix_crsp@devel

Closes #245 fix_crsp: Update CRSP derivation in vignette and template

NEWS.md

@@ -7,7 +7,7 @@
 
 ## Documentation
 
-- The `ADRS` vignette and template were split into two:
+- The `ADRS` vignette and template were split into two (#234):
     - A basic version which uses the `{admiralonco}` functions to cover standard
     RECIST 1.1.
     - A more flexible version which uses `admiral::derive_extreme_event()`. This
@@ -17,6 +17,13 @@
     RECIST 1.1, e.g., iRECIST or International Myeloma Working Group (IMWG)
     criteria for the diagnosis of multiple myeloma.
 
+- The confirmed response derivation was fixed in the basic `ADRS` vignette and
+template. When calling `derive_param_confirmed_resp()` the `filter_source`
+argument has to be set to `PARAMCD == "OVR" & ANL01FL == "Y"` instead of
+`PARAMCD == "OVR" & AVALC %in% c("CR", "PR") & ANL01FL == "Y"`. Otherwise,
+responses like `CR`, `NE`, `NE`, `CR` are considered as confirmed response.
+(#245)
+
 # admiralonco 0.4.0
 
 ## Documentation

inst/templates/ad_adrs_basic.R

@@ -216,7 +216,7 @@ adrs <- adrs %>%
 adrs <- adrs %>%
   derive_param_confirmed_resp(
     dataset_adsl = adsl,
-    filter_source = PARAMCD == "OVR" & AVALC %in% c("CR", "PR") & ANL01FL == "Y",
+    filter_source = PARAMCD == "OVR" & ANL01FL == "Y",
     source_pd = pd,
     source_datasets = list(adrs = adrs),
     ref_confirm = 28,

vignettes/adrs_basic.Rmd

@@ -593,7 +593,7 @@ calculation of days between visits)*, using the `ref_confirm` argument.
 adrs <- adrs %>%
   derive_param_confirmed_resp(
     dataset_adsl = adsl,
-    filter_source = PARAMCD == "OVR" & AVALC %in% c("CR", "PR") & ANL01FL == "Y",
+    filter_source = PARAMCD == "OVR" & ANL01FL == "Y",
     source_pd = pd,
     source_datasets = list(adrs = adrs),
     ref_confirm = 28,