Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

618 templates action@devel #251

Merged
merged 9 commits into from
Sep 18, 2023
Merged

618 templates action@devel #251

merged 9 commits into from
Sep 18, 2023

Conversation

dgrassellyb
Copy link
Collaborator

!!! Please first merge this one before : pharmaverse/admiralci#145 !!!

Please add "Closes #" to the title of the pull request. Then the
issue is closed automatically once it is merged to main.

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

  • Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
  • Updated relevant unit tests or have written new unit tests - See Unit Test Guide
  • If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
  • Update to all relevant roxygen headers and examples
  • Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
  • Address any updates needed for vignettes and/or templates
  • Update NEWS.md
  • Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
  • Address or fix all lintr warnings and errors - lintr::lint_package()
  • Run R CMD check locally and address all errors and warnings - devtools::check()
  • Link the issue so that it closes after successful merging.
  • Address all merge conflicts and resolve appropriately
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

The following line requests to update the man pages by the "Man Pages" workflow.

/roxygenize

@dgrassellyb dgrassellyb changed the base branch from main to devel September 11, 2023 14:31
@github-actions
Copy link

Code Coverage

Package Line Rate Health
admiralonco 97%
Summary 97% (542 / 558)

@dgrassellyb dgrassellyb merged commit 12dee2b into devel Sep 18, 2023
20 of 21 checks passed
@dgrassellyb dgrassellyb deleted the 618_templates_action@devel branch September 18, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants