Closes #253 fix_bor_ne: Add CR and PR to bor_ne event #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rossfarrugia
requested changes
Dec 13, 2023
| @@ -136,11 +136,11 @@ bor_pd <- event( | |||
| #' @export | |||
| bor_ne <- event( | |||
There was a problem hiding this comment.
shouldn't this update be for cbor_ne rather than bor_ne? that's what we did for admiralroche.
There was a problem hiding this comment.
We do not have cbor_ne in admiralonco. We use bor_ne for both BOR and CBOR.
There was a problem hiding this comment.
Do you think we should change this?
There was a problem hiding this comment.
ok, happy to go with your call as I see similar case with bor_sd. i'll approve for now and then if you decide to update i can re-review.
There was a problem hiding this comment.
we should also update ibor_ne for iRECIST
There was a problem hiding this comment.
Good point.
Updated
rossfarrugia
approved these changes
Dec 13, 2023
starosto
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your Pull Request! We have developed this task checklist from the
Development Process
Guide
to help with the final steps of the process. Completing the below tasks helps to
ensure our reviewers can maximize their time on your code as well as making sure
the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task
or check off that it is not relevant to your Pull Request. This checklist is
part of the Github Action workflows and the Pull Request will not be merged into
the
mainbranch until you have checked off each task.main.styler::style_file()to style R and Rmd filesdevtools::document()so all.Rdfiles in themanfolder and theNAMESPACEfile in the project root are updated appropriatelyNEWS.mdpkgdown::build_site()and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()R CMD checklocally and address all errors and warnings -devtools::check()The following line requests to update the man pages by the "Man Pages" workflow.
/roxygenize