Closes #237: deprecation

[ukey1025]

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral family codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

• Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update).
• Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files.
• Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
• If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
• Update to all relevant roxygen headers and examples, including keywords and families. Refer to the [categorization of functions]
• Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately.
• Address any updates needed for vignettes and/or templates
• Update NEWS.md under the header # admiralophtha (development version) if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
• Build admiralophtha site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
• Address or fix all lintr warnings and errors - lintr::lint_package().
• Run R CMD check locally and address all errors and warnings - devtools::check().
• Link the issue so that it closes after successful merging.
• Address all merge conflicts and resolve appropriately.
• Pat yourself on the back for a job well done! Much love to your accomplishment!

[manciniedoardo]

Thanks @ukey1025.

• Please update the roxygen header of derive_var_afeye,R to remove references to dataset_occ and lat_vals.
• Please remove the deprecation tests for these arguments as well (see here) as they will fail otherwise.

[manciniedoardo]

@ukey1025:

• please fix the code style check by running: styler::style_file("R/derive_var_afeye.R")
• please fix the man pages check by running: roxygen2::roxygenize('.', roclets = c('rd', 'collate', 'namespace'))

[manciniedoardo]

@ukey1025 sorry it took me a while to get to this. I found what the issue is: you correctly removed lat_vals as an argument to derive_var_afeye() but line 67 of derive_var_afeye() should also be removed as the object doesn't exist anymore.