Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #254 Replace exprs(STUDYID, USUBJID) with get_admiral_option("subject_keys") in by_vars input of derive_vars_merged() #255

Conversation

steventing12
Copy link
Collaborator

@steventing12 steventing12 commented Nov 4, 2024

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral family codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update).
  • Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files.
  • Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
  • If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
  • Update to all relevant roxygen headers and examples, including keywords and families. Refer to the [categorization of functions]
  • Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately.
  • Address any updates needed for vignettes and/or templates
  • Update NEWS.md under the header # admiralophtha (development version) if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
  • Build admiralophtha site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
  • Address or fix all lintr warnings and errors - lintr::lint_package().
  • Run R CMD check locally and address all errors and warnings - devtools::check().
  • Link the issue so that it closes after successful merging.
  • Address all merge conflicts and resolve appropriately.
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

…ubject_keys") in by_vars input of derive_vars_merged()
@steventing12 steventing12 changed the title feat: #254 Replace exprs(STUDYID, USUBJID) with get_admiral_option("subject_keys") in by_vars input of derive_vars_merged() Closes #254 Replace exprs(STUDYID, USUBJID) with get_admiral_option("subject_keys") in by_vars input of derive_vars_merged() Nov 4, 2024
@manciniedoardo
Copy link
Collaborator

@steventing12 as discussed, you need to add get_admiral_option to the right bit of R/admiralophtha-package.R

Copy link

github-actions bot commented Nov 14, 2024

Code Coverage

Package Line Rate Health
admiralophtha 100%
Summary 100% (133 / 133)

@manciniedoardo
Copy link
Collaborator

@steventing12 FYI the reason the tests were failing is because you hadn't added get_admiral_option() to the list of imported functions from {admiral} in admiralophtha-package.R - now I've done it and it all looks good!

@manciniedoardo manciniedoardo merged commit 20de30d into main Nov 14, 2024
17 checks passed
@manciniedoardo manciniedoardo deleted the 254-general-issue-derive_var_studyeye-accidentally-uses-hardcoded-subject-keys branch November 14, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

General Issue: derive_var_studyeye() accidentally uses hardcoded subject keys
2 participants