Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
closes #71 closes #74 closes #78 updates from admiralpeds experience #79
closes #71 closes #74 closes #78 updates from admiralpeds experience #79
Changes from all commits
e963bd3
c9f53fa
fb95f67
d087f99
9d4fcdf
d4bc008
f70c37b
7caf1a9
b3a7ca1
0ef7f24
73e6fc4
7a960ed
3639e72
a59bd89
79124b0
aae0058
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I sort of like the news … history of what we have done! Was this confusing for folks? I like the message it sends that we catalog changes even for our template repo :) but if y’all think it’s got to go then all good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say people can look to admiral or other pkg ext news files for examples. the confusing thing in having it was that every new pkg ext team starts logging every change from the start but in reality you only need this populated after you make first release, as everything until then is just release 1 features and not changes that users need to be aware of.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay that makes sense. I was referring to the actual news for working on admiraltemplate, but it sounds like that is going to be jettison which is fine.
This file was deleted.