Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #225, Closes #228, Closes #229: Updates on Navbar Description and admiral core impacts #226

Merged
merged 36 commits into from
Dec 21, 2023

Conversation

arjoon-r
Copy link
Collaborator

@arjoon-r arjoon-r commented Nov 6, 2023

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
  • Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
  • Updated relevant unit tests or have written new unit tests - See Unit Test Guide
  • If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
  • Update to all relevant roxygen headers and examples.
  • Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
  • Address any updates needed for vignettes and/or templates
  • Update NEWS.md if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
  • Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
  • Address or fix all lintr warnings and errors - lintr::lint_package()
  • Run R CMD check locally and address all errors and warnings - devtools::check()
  • Link the issue so that it closes after successful merging.
  • Address all merge conflicts and resolve appropriately.
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

@arjoon-r arjoon-r added the documentation Improvements or additions to documentation label Nov 6, 2023
@arjoon-r arjoon-r self-assigned this Nov 6, 2023
Updated the admiral link
Copy link

github-actions bot commented Nov 6, 2023

Code Coverage

Package Line Rate Health
admiralvaccine 99%
Summary 99% (375 / 378)

@ahasoplakus
Copy link
Collaborator

Hi @arjoon-r could you fix the CI/CD checks?

included the new argument - `join_type` in derive_vars_joined
included the new argument - `join_type` in derive_vars_joined
included the new argument - `join_type` in derive_vars_joined
included the new argument - `join_type` in derive_vars_joined
included the new argument - `join_type` in derive_vars_joined
upated the extreme record arguments
included the new argument - `join_type` in derive_vars_joined
@arjoon-r arjoon-r changed the title 225 navbar update and description 225 229 Updates on Navbar Description and admiral core impacts Nov 30, 2023
@ahasoplakus ahasoplakus changed the title 225 229 Updates on Navbar Description and admiral core impacts Closes #225, #229 Updates on Navbar Description and admiral core impacts Dec 6, 2023
@ahasoplakus ahasoplakus changed the title Closes #225, #229 Updates on Navbar Description and admiral core impacts Closes #225, #229: Updates on Navbar Description and admiral core impacts Dec 6, 2023
@arjoon-r
Copy link
Collaborator Author

arjoon-r commented Dec 7, 2023

image
Hi @manciniedoardo, I am facing this error in all the jobs except the checks. But everything got passed in devtools::check() in my local R studio. seems like something to do with admiralci. Could you take a look at it?

@ahasoplakus ahasoplakus changed the title Closes #225, #229: Updates on Navbar Description and admiral core impacts Closes #225, closes #229: Updates on Navbar Description and admiral core impacts Dec 7, 2023
@manciniedoardo
Copy link

Hi @dgrassellyb do you know what's going on here? thanks!

@ahasoplakus
Copy link
Collaborator

Hi @dgrassellyb do you know what's going on here? thanks!

Hi @manciniedoardo @dgrassellyb Any update on this?

@ahasoplakus ahasoplakus changed the title Closes #225, closes #229: Updates on Navbar Description and admiral core impacts Closes #225, Closes #228, Closes #229: Updates on Navbar Description and admiral core impacts Dec 20, 2023
@ahasoplakus ahasoplakus changed the base branch from devel to main December 21, 2023 09:48
@ahasoplakus ahasoplakus merged commit 8817555 into main Dec 21, 2023
16 of 17 checks passed
@ahasoplakus ahasoplakus deleted the 225_navbar_update_and_description branch December 21, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: In Review
4 participants