Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #239 Remove styler dependency #241

Merged
merged 2 commits into from
Jul 31, 2024

Merge branch 'main' into 239-general-issue-remove-styler-dependency

df068a4
Select commit
Loading
Failed to load commit list.
Merged

Closes #239 Remove styler dependency #241

Merge branch 'main' into 239-general-issue-remove-styler-dependency
df068a4
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed Started 2024-07-31 14:30:37 ago

0 / 14 tasks completed

14 tasks still to be completed

Details

Required Tasks

Task Status
Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update) Incomplete
Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files Incomplete
Updated relevant unit tests or have written new unit tests - See Unit Test Guide Incomplete
If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance? Incomplete
Update to all relevant roxygen headers and examples. Incomplete
Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately Incomplete
Address any updates needed for vignettes and/or templates Incomplete
Update NEWS.md if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers) Incomplete
Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page. Incomplete
Address or fix all lintr warnings and errors - lintr::lint_package() Incomplete
Run R CMD check locally and address all errors and warnings - devtools::check() Incomplete
Link the issue so that it closes after successful merging. Incomplete
Address all merge conflicts and resolve appropriately. Incomplete
Pat yourself on the back for a job well done! Much love to your accomplishment! Incomplete