-
Notifications
You must be signed in to change notification settings - Fork 11
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
* feat: #96 image and skeleton * feat: new functions section started * feat: onboarding resources * feat: #96 finishing ef_msrc section * feat: #96 finished function section. working on bug and argument section * feat: #96 stability section * Update posts/2023-12-18_admiral_1_0/admiral_1_0.qmd Co-authored-by: Edoardo Mancini <[email protected]> * Update posts/2023-12-18_admiral_1_0/admiral_1_0.qmd Co-authored-by: Edoardo Mancini <[email protected]> * Update posts/2023-12-18_admiral_1_0/admiral_1_0.qmd Co-authored-by: Edoardo Mancini <[email protected]> * Update posts/2023-12-18_admiral_1_0/admiral_1_0.qmd Co-authored-by: Edoardo Mancini <[email protected]> * Update posts/2023-12-18_admiral_1_0/admiral_1_0.qmd Co-authored-by: Edoardo Mancini <[email protected]> * Update posts/2023-12-18_admiral_1_0/admiral_1_0.qmd Co-authored-by: Edoardo Mancini <[email protected]> * Update posts/2023-12-18_admiral_1_0/admiral_1_0.qmd Co-authored-by: Edoardo Mancini <[email protected]> * Update posts/2023-12-18_admiral_1_0/admiral_1_0.qmd Co-authored-by: Edoardo Mancini <[email protected]> * Update posts/2023-12-18_admiral_1_0/admiral_1_0.qmd Co-authored-by: Edoardo Mancini <[email protected]> * Update posts/2023-12-18_admiral_1_0/admiral_1_0.qmd Co-authored-by: Edoardo Mancini <[email protected]> * chore: #96 remove duplicate post. enable dark mode * feat: #96 way back machine introduced * fix: #96 review comments * chore: #96 style and spelling * chore: #96 ignore appsilon link. spelling --------- Co-authored-by: Edoardo Mancini <[email protected]>
- Loading branch information
1 parent
97193e5
commit 3221e3a
Showing
15 changed files
with
323 additions
and
62 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,290 @@ | ||
--- | ||
title: "admiral 1.0.0" | ||
author: | ||
- name: Ben Straub | ||
description: "1.0.0 brings a commitment to stability, new features, a few bug fixes, argument alignment and onboarding resources!" | ||
date: "2024-01-04" | ||
# please do not use any non-default categories. | ||
# You can find the default categories in the repository README.md | ||
categories: [admiral, ADaMs] | ||
# feel free to change the image | ||
image: "new_features.jpg" | ||
|
||
--- | ||
|
||
<!--------------- typical setup -----------------> | ||
|
||
```{r setup, include=FALSE} | ||
long_slug <- "2023-12-18_admiral_1_0" | ||
# renv::use(lockfile = "renv.lock") | ||
``` | ||
|
||
<!--------------- post begins here -----------------> | ||
|
||
[`admiral 1.0.0`](https://pharmaverse.github.io/admiral/index.html) is out on [CRAN](https://cran.r-project.org/web/packages/admiral/index.html). This release brings several new features to your tool set | ||
for working with ADaMs in R. [`admiral 1.0.0`](https://pharmaverse.github.io/admiral/index.html) also brings needed stability to users who were wishing | ||
to adopt [admiral](https://pharmaverse.github.io/admiral/index.html), but were a little worried by the fast deprecation and experimentation for `pre-v1.0.0` releases. | ||
|
||
This blog post will discuss our commitment to stability, walk you through the new features available, discuss some of the bug fixes, a push for common APIs across our functions, and showcase the resources available to help you on-board to [admiral](https://pharmaverse.github.io/admiral/index.html). | ||
|
||
# Commitment to Stability | ||
|
||
`{admiral}` was born out of a conversation between Thomas Neitmann and Michael Rimler almost three years ago. Check out this [history blog post](https://pharmaverse.github.io/blog/posts/2023-10-10_pharmaverse_story/pharmaverse_story.html) for some of additional context on its development. Over the last three years, we have worked at a furious pace to produce functions that can do almost all derivations needed for common ADaMs. However, we have noticed that some functions are very similar to others and with some minor tweaks could be made redundant in favor of other functions. This has lead to some deprecation of either whole functions or arguments as we have sought to consolidate. Unfortunately, this creates a lot of frustration for users. | ||
|
||
Enter Superseded!! | ||
|
||
Now with the release of `1.0.0` we are going to _supersede_ functions going forward. This is the process where when we introduce new functions to replace other functions, we will no longer fast-deprecate the replaced functions. Now we will supersede them, i.e. we will keep the function in the codebase for a long time, but recommend the use of the new function. If the function were to be removed from the codebase this will be done many years from the time it is superseded. Please note that although superseded functions are not in scope for active development, any bugs identified within them will nevertheless be fixed. | ||
|
||
|
||
# New Features | ||
|
||
We have 3 new functions available in this release: | ||
|
||
* [derive_vars_extreme_event()](https://pharmaverse.github.io/admiral/reference/derive_vars_extreme_event.html) | ||
* [derive_var_merged_ef_msrc()](https://pharmaverse.github.io/admiral/reference/derive_var_merged_ef_msrc.html) | ||
* [derive_vars_computed()](https://pharmaverse.github.io/admiral/reference/derive_vars_computed.html) | ||
|
||
and a new option in [derive_var_atoxgr_dir()](https://pharmaverse.github.io/admiral/reference/derive_var_atoxgr_dir.html) and [derive_var_anrind()](https://pharmaverse.github.io/admiral/reference/derive_var_anrind.html) to handle floating point issues. | ||
|
||
## `derive_vars_extreme_event()` | ||
|
||
This function takes available records from user-defined events by selecting the extreme observations and appending them as a variable(s) to your dataset. [derive_vars_extreme_event()](https://pharmaverse.github.io/admiral/reference/derive_vars_extreme_event.html) works similar to [`derive_extreme_event()`](https://pharmaverse.github.io/admiral/reference/derive_extreme_event.html), but instead of adding observations the function will add variable(s). | ||
|
||
Let's take a peek with a very simple example where we just use ADSL! The documentation for | ||
[derive_vars_extreme_event()](https://pharmaverse.github.io/admiral/reference/derive_vars_extreme_event.html) has a much richer example with events from other domains that is more aligned to where you would use this function. | ||
|
||
Let us make some dummy `ADSL` data and load up our packages. The goal here is to add two new variables `LSTALVDT` and `DTHFL` based on a list of objects that are used to specify the following: | ||
|
||
- the dataset to look at | ||
- a set of conditions | ||
- what to set the values for the new variables | ||
|
||
```{r, message = FALSE, warning = FALSE} | ||
library(tibble) | ||
library(admiral) | ||
library(lubridate) | ||
adsl <- tribble( | ||
~STUDYID, ~USUBJID, ~TRTEDT, ~DTHDT, | ||
"PILOT01", "01-1130", ymd("2014-08-16"), ymd("2014-09-13"), | ||
"PILOT01", "01-1133", ymd("2013-04-28"), ymd(""), | ||
"PILOT01", "01-1211", ymd("2013-01-12"), ymd(""), | ||
"PILOT01", "09-1081", ymd("2014-04-27"), ymd(""), | ||
"PILOT01", "09-1088", ymd("2014-10-09"), ymd("2014-11-01"), | ||
) | ||
``` | ||
|
||
|
||
|
||
In this example, we only use `ADSL` as the source dataset, so it is a bit contrived, but much more compact for us. Note the use of the `events` that is taking in our list of event objects and the different conditions and values we set to create our `LSTALVDT` and `DTHFL` variables. | ||
|
||
```{r} | ||
derive_vars_extreme_event( | ||
adsl, | ||
by_vars = exprs(STUDYID, USUBJID), | ||
events = list( | ||
event( | ||
dataset_name = "adsl", | ||
condition = !is.na(DTHDT), | ||
set_values_to = exprs(LSTALVDT = DTHDT, DTHFL = "Y") | ||
), | ||
event( | ||
dataset_name = "adsl", | ||
condition = !is.na(TRTEDT), | ||
set_values_to = exprs(LSTALVDT = TRTEDT, DTHFL = "N") | ||
) | ||
), | ||
source_datasets = list(adsl = adsl), | ||
order = exprs(LSTALVDT), | ||
mode = "last", | ||
new_vars = exprs(LSTALVDT = LSTALVDT, DTHFL = DTHFL) | ||
) | ||
``` | ||
|
||
Okay! We used a very small example to showcase how to find extreme observations and | ||
appending this information as new variables to our `ADSL` dataset. Highly recommend checking | ||
out the more detailed example in the [function documentation](https://pharmaverse.github.io/admiral/reference/derive_vars_extreme_event.html) to see its true power! | ||
|
||
## `derive_var_merged_ef_msrc()` | ||
|
||
This function has some similarity to [derive_vars_extreme_event()](https://pharmaverse.github.io/admiral/reference/derive_vars_extreme_event.html), but now we are only looking at adding a single flag variable based on checking conditions across multiple datasets. | ||
|
||
We develop some _simple_ dummy data for `ADSL`, `CM` and `PR`. Our goal is to flag patients who have `CMCAT = "ANTI-CANCER"` in the `CM` dataset or have records in the `PR` dataset. Any participants who meet these conditions will have our new variable `CANCTRFL` set as `"Y"`. | ||
|
||
```{r, message = FALSE, warning = FALSE} | ||
adsl <- tribble( | ||
~USUBJID, | ||
"1", | ||
"2", | ||
"3", | ||
"4", | ||
) | ||
cm <- tribble( | ||
~USUBJID, ~CMCAT, ~CMSEQ, | ||
"1", "ANTI-CANCER", 1, | ||
"1", "GENERAL", 2, | ||
"2", "GENERAL", 1, | ||
"3", "ANTI-CANCER", 1 | ||
) | ||
pr <- tribble( | ||
~USUBJID, ~PRSEQ, | ||
"2", 1, | ||
"3", 1 | ||
) | ||
``` | ||
|
||
|
||
Now we have the argument `flag_events` that takes a list of objects where we define the conditions and datasets to check in. | ||
|
||
```{r} | ||
derive_var_merged_ef_msrc( | ||
adsl, | ||
flag_events = list( | ||
flag_event( | ||
dataset_name = "cm", | ||
condition = CMCAT == "ANTI-CANCER" | ||
), | ||
flag_event( | ||
dataset_name = "pr" | ||
) | ||
), | ||
source_datasets = list(cm = cm, pr = pr), | ||
by_vars = exprs(USUBJID), | ||
new_var = CANCTRFL | ||
) | ||
``` | ||
|
||
Let's go! We searched over multiple datasets, `CM` and `PR`, with multiple conditions and appended a new variable `CANCTRFL` to `ADSL` setting to `"Y"` if those conditions were met. | ||
|
||
## `derive_vars_computed()` | ||
|
||
This function is very similar to [derive_param_computed()](https://pharmaverse.github.io/admiral/reference/derive_param_computed.html), but instead of adding observations we are going to add variable(s). Very handy when wanting to add some additional variables to `ADSL`, e.g. baseline variables. | ||
|
||
Let's make some dummy data for an `ADSL` and `ADVS`. Our goal is to derive a `BMIBL` variable pulled from `ADVS` and append to `ADSL`. | ||
|
||
```{r} | ||
adsl <- tribble( | ||
~STUDYID, ~USUBJID, ~AGE, ~AGEU, | ||
"PILOT01", "01-1302", 61, "YEARS", | ||
"PILOT01", "17-1344", 64, "YEARS" | ||
) | ||
advs <- tribble( | ||
~STUDYID, ~USUBJID, ~PARAMCD, ~PARAM, ~VISIT, ~AVAL, ~AVALU, ~ABLFL, | ||
"PILOT01", "01-1302", "HEIGHT", "Height (cm)", "SCREENING", 177.8, "cm", "Y", | ||
"PILOT01", "01-1302", "WEIGHT", "Weight (kg)", "SCREENING", 81.19, "kg", "N", | ||
"PILOT01", "01-1302", "WEIGHT", "Weight (kg)", "BASELINE", 82.1, "kg", "Y", | ||
"PILOT01", "01-1302", "WEIGHT", "Weight (kg)", "WEEK 2", 81.19, "kg", "N", | ||
"PILOT01", "01-1302", "WEIGHT", "Weight (kg)", "WEEK 4", 82.56, "kg", "N", | ||
"PILOT01", "01-1302", "WEIGHT", "Weight (kg)", "WEEK 6", 80.74, "kg", "N", | ||
"PILOT01", "17-1344", "HEIGHT", "Height (cm)", "SCREENING", 163.5, "cm", "Y", | ||
"PILOT01", "17-1344", "WEIGHT", "Weight (kg)", "SCREENING", 58.06, "kg", "N", | ||
"PILOT01", "17-1344", "WEIGHT", "Weight (kg)", "BASELINE", 58.06, "kg", "Y", | ||
"PILOT01", "17-1344", "WEIGHT", "Weight (kg)", "WEEK 2", 58.97, "kg", "N", | ||
"PILOT01", "17-1344", "WEIGHT", "Weight (kg)", "WEEK 4", 57.97, "kg", "N", | ||
"PILOT01", "17-1344", "WEIGHT", "Weight (kg)", "WEEK 6", 58.97, "kg", "N" | ||
) | ||
``` | ||
|
||
Take a look at how we use `new_vars` and `filter_add`. We use a function inside of `new_vars` to help us calculate the `BMI` while using the `filter_add` argument to only look at baseline records for the calculation. | ||
|
||
```{r} | ||
derive_vars_computed( | ||
dataset = adsl, | ||
dataset_add = advs, | ||
by_vars = exprs(STUDYID, USUBJID), | ||
parameters = c("WEIGHT"), | ||
constant_by_vars = exprs(STUDYID, USUBJID), | ||
constant_parameters = c("HEIGHT"), | ||
new_vars = exprs(BMIBL = compute_bmi(height = AVAL.HEIGHT, weight = AVAL.WEIGHT)), | ||
filter_add = ABLFL == "Y" | ||
) | ||
``` | ||
|
||
Alright! Simple enough. We just took records from `ADVS`to help us calculate the `BMI` at baseline using this function and appended our new variable to `ADSL`. | ||
|
||
# Argument Alignment and Bug Fixes | ||
|
||
## Argument Alignment | ||
|
||
A huge push was made for `1.0.0` to help align our arguments across all of `{admiral}` functions. What does this mean? We identified arguments in functions where the argument did the same things but was slightly named differently. For `1.0.0`, we really want users to have a solid API for `{admiral}` functions. | ||
|
||
Let's take a peak at the function [`consolidate_metadata()`](https://pharmaverse.github.io/admiral/reference/consolidate_metadata.html) to even better understand our goal here. | ||
|
||
``` | ||
consolidate_metadata( | ||
datasets, | ||
key_vars, | ||
source_var = SOURCE, | ||
check_vars = "warning", | ||
check_keys, | ||
check_type = "error" | ||
) | ||
``` | ||
|
||
In previous versions of `{admiral}` the `consolidate_metadata()` function had the argument `check_keys`, which helps to check uniqueness. Other functions had a similar argument, but were called `check_unique`. Therefore, to better align our common API for `{admiral}` functions we decided to rename the `check_keys` argument to `check_unique`. You can follow the discussion around this renaming effort in this [GitHub Issue](https://github.com/pharmaverse/admiral/issues/2184). | ||
|
||
```{r, fig.align = 'center', echo=FALSE} | ||
knitr::include_graphics("check.png") | ||
``` | ||
|
||
|
||
The argument has a deprecated tag in the function documentation and will issue a warning to users. There was quite a bit of renaming of arguments for `1.0.0` so there are quite a few of these tags in our documentation. In subsequent releases, these arguments will be removed. Please see the [changelog](https://pharmaverse.github.io/admiral/news/index.html#admiral-100) if you would like to explore other functions that had arguments renamed. The issues are linked to each rename so you can follow along with the discussions! | ||
|
||
## Bug Fixes | ||
|
||
We love fixing bugs and take them incredibly seriously - especially when identified by members from the community. | ||
|
||
If you find a pesky bug, please fill out a [Bug Report](https://github.com/pharmaverse/admiral/issues/new/choose) on our Issues Tab. | ||
|
||
Each bug fixed by our development team is documented in our [changelog](https://pharmaverse.github.io/admiral/news/index.html#updates-of-existing-functions-1-0-0) with the Issue linked. | ||
|
||
```{r, fig.align = 'center', echo=FALSE} | ||
knitr::include_graphics("issue_tag.png") | ||
``` | ||
|
||
|
||
For example, if you click through the issue for [`derive_extreme_event()`](https://github.com/pharmaverse/admiral/issues/2291) that identified a problem where the `condition` was ignored if the `mode` argument was used, you can see the Bug Report along with a reproducible example. You can also see the Pull Request for the exact code changes that are addressing this bug linked in the Issue! Way cool! | ||
|
||
|
||
# New On-boarding Resources | ||
|
||
`{admiral}` has a lot of functions for working with ADaMs. This can be overwhelming for new users and we really sympathize. To help new users onboarding to `{admiral}` we have developed the following resources: | ||
|
||
## [admiraldiscovery](https://pharmaverse.github.io/admiraldiscovery/index.html) | ||
|
||
This is a dedicated website that lists out in a tabular format standard ADaM datasets and their common variables with corresponding `{admiral}` functions that could be used to create the variables. Very handy when you just want to get some starter code on deriving `EOSDT` or `TRTSDT`! | ||
|
||
|
||
```{r, fig.align = 'center', echo=FALSE} | ||
knitr::include_graphics("admiraldisc.png") | ||
``` | ||
|
||
|
||
## [admiral Cheat Sheet](https://github.com/pharmaverse/admiral/blob/main/inst/cheatsheet/admiral_cheatsheet.pdf) | ||
|
||
Inspired by other R package cheat sheets! We try and surface commonly needed functions for doing ADaM derivations with simple tables to show how the data is transforming. | ||
|
||
```{r, fig.align = 'center', echo=FALSE} | ||
knitr::include_graphics("cheatsheet.png") | ||
``` | ||
|
||
## Way Back Machine | ||
|
||
Studies can last a long time. Adopting R as your primary analysis language for your study can introduce certain risks around package dependencies. Fixing those dependencies to certain package versions can help mitigate those risks. Unfortunately, as package websites are updated those helpful documents, examples and vignettes can be lost as the version changes. Do not lose heart `{admiral}` users. If you decided to fix to a certain version of `{admiral}`, we have you covered with our __Way Back Machine__ that allows you to change the website documentation back to the version you are using. | ||
|
||
```{r, fig.align = 'center', echo=FALSE} | ||
knitr::include_graphics("wayback.png") | ||
``` | ||
|
||
<!--------------- appendices go here -----------------> | ||
|
||
```{r, echo=FALSE} | ||
source("appendix.R") | ||
insert_appendix( | ||
repo_spec = "pharmaverse/blog", | ||
name = long_slug | ||
) | ||
``` |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
File renamed without changes.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.