-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #58 fixed appendix #152
Closes #58 fixed appendix #152
Conversation
Still in draft, and was not able to re-knit everything, and only did it for one example so far. |
Should we reconsider whether we want renv.lock files? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the Quarto Publish job publishes it takes the latest CRAN package. Will this get updated when that is run?
AFAIK it will get updated whenever the qmd is rendered. |
insert_appendix <- function(repo_spec, name, collection = "posts", file_name) { | ||
# write session info to txt | ||
session_info <- sessionInfo() | ||
writeLines(capture.output(session_info), con = "session_info.txt") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure this overwrites!
Cool!! Can you fix the actions and then we can merge in and see what it does!?! |
|
@bms63 I added a site to the blog including the session info. Please feel free to render and check out the floating point post, thats where I adjusted the appendix function so far. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So in the ci job this will update the packages in each blog post as well as provide a global session info page?
I had a chance to render the site locally - looks good. Can you make a note of this process in the Readme and add a note for the reviewer to verify that this is in the blog post folder. I don't really want to make this update across all the posts, unless you want to do it. I only want to do this going forward. Choose your adventure! :) Thanks again. |
Hi @bms63 can we merge this into main so I can be sure that all the links work fine on the main branch? |
@bms63 not sure why this link does not work: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the reference to the session info - smart!
Why do we need the roxygen package?
As an admin you can just bypass normal PR stuff if you are experimenting. Just don't leave the site broken!!
Thank you for your Pull Request! We have developed this task checklist to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your blog post.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
main
branch until you have checked off each task.CICD.R
line by line to first check the spelling in your post and then to make sure your code is compatible with our code-style. Address any incongruences by following the instructions in the file!tag(s)
or categories from the current list:c("Metadata", "SDTM", "ADaM", "TLG", "Shiny", "Community", "Conferences", "Submissions", "Technical")
for your blog post. If you cannot find anything that fits your blog post, add your own tag! We occasionally tidy up alltags
for consistency.description
field at the top of the markdown document.This blog contains opinions that are of the authors alone and do not necessarily reflect the strategy of their respective organizations.)