-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #184 Automatically updating the date of new blog posts #222
Conversation
The idea here is that posts now get created in a folder prefixed with |
Not a bad idea, but I don't understand how this will affect the main branch. |
I tested this in a Only question is whether we need to update the branch restrictions on |
Hmm I think the part that says |
@StefanThoma I'm testing again with dummy branches - possible that I got this wrong during my first test |
You're right. I think we'd actually need to checkout main, do the update there, and then push? |
We also have to be mindful of the order, so that the date is adjusted before the publishing job runs, right? |
Great point - maybe this workflow should be added as a dependency of the publishing job? |
Ok, it should be fixed now - took a couple of attempts... Thanks @StefanThoma! |
@StefanThoma I updated the publishing job as well with a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoa...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you for your Pull Request! We have developed this task checklist to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your blog post.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
main
branch until you have checked off each task.CICD.R
line by line to first check the spelling in your post and then to make sure your code is compatible with our code-style. Address any incongruences by following the instructions in the file!tag(s)
or categories from the current list:c("Metadata", "SDTM", "ADaM", "TLG", "Shiny", "Community", "Conferences", "Submissions", "Technical")
for your blog post. If you cannot find anything that fits your blog post, propose a new tag to the maintainers! Note: if you use a tag not from this list, the "Check Post Tags" CICD pipeline will error. We occasionally tidy up alltags
for consistency.description
field at the top of the markdown document.This blog contains opinions that are of the authors alone and do not necessarily reflect the strategy of their respective organizations.)