Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #234 Blog Post: How I Rebuilt a Lost ECG Data Script in R #235

Merged
merged 15 commits into from
Oct 31, 2024

Conversation

vbshuliar
Copy link
Collaborator

@vbshuliar vbshuliar commented Sep 30, 2024

Thank you for your Pull Request! We have developed this task checklist to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your blog post.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update), and make sure the corresponding issue is linked in the Development section on the right hand side
  • Ensure your new post folder is of the form "posts/zzz_DO_NOT_EDIT_<your post title>". This is so that the post date can be auto-updated upon the merge into main.
  • Run the script from CICD.R line by line to first check the spelling in your post and then to make sure your code is compatible with our code-style. Address any incongruences by following the instructions in the file!
  • Choose (possibly several) tag(s) or categories from the current list: c("Metadata", "SDTM", "ADaM", "TLG", "Shiny", "Community", "Conferences", "Submissions", "Technical") for your blog post. If you cannot find anything that fits your blog post, propose a new tag to the maintainers! Note: if you use a tag not from this list, the "Check Post Tags" CICD pipeline will error. We occasionally tidy up all tags for consistency.
  • Add a short description for your blog post in the description field at the top of the markdown document.
  • Blog post is short, personalized, reproducible and readable
  • Add a disclaimer at the top of your post, if appropriate (example: Disclaimer
    This blog contains opinions that are of the authors alone and do not necessarily reflect the strategy of their respective organizations.)
  • Address all merge conflicts and resolve appropriately
  • Assign two of us (@bms63, @manciniedoardo, @StefanThoma, @kaz462) as reviewers in the PR.
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

@vbshuliar vbshuliar added the good first issue Good for newcomers label Sep 30, 2024
@vbshuliar vbshuliar self-assigned this Sep 30, 2024
@vbshuliar vbshuliar changed the title Closes #234 Blog post successfully finished Closes #234 Blog Post: How I Rebuilt a Lost ECG Data Script in R Sep 30, 2024
@manciniedoardo
Copy link
Collaborator

@reviewers: I will work with @vbshuliar for a first review cycle and once that is complete please feel free to add your own comments as well.

@vbshuliar
Copy link
Collaborator Author

@manciniedoardo I've added a bit of explanation for some of the eg script code bits to the post. Also, locally I am not getting any spelling errors. They are only in the pipeline.

Copy link
Collaborator

@manciniedoardo manciniedoardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vbshuliar thanks for the post! I left a tonne of comments but don't be scared, it has the makings of a super post so thanks for your time 😄 !

@vbshuliar
Copy link
Collaborator Author

@manciniedoardo ,
Please check out the new version of the post. I tried to take all the recommendations into account.

Copy link
Collaborator

@manciniedoardo manciniedoardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Left another round of comments

@vbshuliar
Copy link
Collaborator Author

vbshuliar commented Oct 14, 2024

@manciniedoardo ,
Please, check out the new version of the post.

@vbshuliar
Copy link
Collaborator Author

@manciniedoardo I took all your feedback into account and prepared a new version of the post. Please, check it.

Copy link
Collaborator

@manciniedoardo manciniedoardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vbshuliar looks great! I did one final round of review, but I think it's ready for other reviewers too now @gigikenneth @kaz462

@vbshuliar
Copy link
Collaborator Author

@manciniedoardo Please, check the new version with all the recommendations implemented.

Copy link
Collaborator

@manciniedoardo manciniedoardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@StefanThoma StefanThoma self-requested a review October 31, 2024 07:56
Copy link
Collaborator

@StefanThoma StefanThoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes requested.

Copy link
Collaborator

@StefanThoma StefanThoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick updates!

@manciniedoardo manciniedoardo merged commit 629b28e into main Oct 31, 2024
5 checks passed
@manciniedoardo manciniedoardo deleted the 234-how-i-rebuilt-a-lost-ecg-data-script-in-r branch October 31, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants