Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #189 #236

Merged
merged 5 commits into from
Oct 24, 2024
Merged

Closes #189 #236

merged 5 commits into from
Oct 24, 2024

Conversation

telepath37
Copy link
Collaborator

Thank you for your Pull Request! We have developed this task checklist to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your blog post.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update), and make sure the corresponding issue is linked in the Development section on the right hand side
  • Ensure your new post folder is of the form "posts/zzz_DO_NOT_EDIT_<your post title>". This is so that the post date can be auto-updated upon the merge into main.
  • Run the script from CICD.R line by line to first check the spelling in your post and then to make sure your code is compatible with our code-style. Address any incongruences by following the instructions in the file!
  • Choose (possibly several) tag(s) or categories from the current list: c("Metadata", "SDTM", "ADaM", "TLG", "Shiny", "Community", "Conferences", "Submissions", "Technical") for your blog post. If you cannot find anything that fits your blog post, propose a new tag to the maintainers! Note: if you use a tag not from this list, the "Check Post Tags" CICD pipeline will error. We occasionally tidy up all tags for consistency.
  • Add a short description for your blog post in the description field at the top of the markdown document.
  • Blog post is short, personalized, reproducible and readable
  • Add a disclaimer at the top of your post, if appropriate (example: Disclaimer
    This blog contains opinions that are of the authors alone and do not necessarily reflect the strategy of their respective organizations.)
  • Address all merge conflicts and resolve appropriately
  • Assign two of us (@bms63, @manciniedoardo, @StefanThoma, @kaz462) as reviewers in the PR.
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

@telepath37
Copy link
Collaborator Author

not sure what happens with the 'links failing'...it seems to come from other posts, which I didn't touch...

@StefanThoma
Copy link
Collaborator

Looks like the following links from other blogposts fail:

Errors in posts/2024-08-15_top_five_pharmaverse_packages/top-five-packages.md

Errors in posts/2024-07-24_working__groups_.../working__groups__updates.md

Errors in posts/2023-08-14_rhino_submission_2/rhino_submission_2.md

I cannot access them either.
@bms63 do you know what's going on?

@StefanThoma StefanThoma mentioned this pull request Oct 1, 2024
@bms63
Copy link
Collaborator

bms63 commented Oct 1, 2024

Sadly things just break and urls don't re-direct. If you can't easily find replacements then we can just let the links go through and see if they get fixed/fixed ourselves later.

@StefanThoma
Copy link
Collaborator

Links should get fixed in #238

Copy link
Collaborator

@StefanThoma StefanThoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good as an update.
Generally, we suggest using the link package to add links to package mentions, but as this is an update to an existing post it is fine as is.
Also, consider renaming the falcon.qmd file to cardinal.qmd.
But I'll leave this up to you.

Copy link
Collaborator

@StefanThoma StefanThoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@StefanThoma
Copy link
Collaborator

@bms63 can you approve this as well?

Copy link
Collaborator

@bms63 bms63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change qmd file to cardinal.

Is this going to be a package or more of catalog of TLFs?? If going to be package - any timelines on going to CRAN/already on CRAN?

Could we make the title a little more spicier?

  • cardinal - collaborative effort to harmonize TLGs for clinical study reporting
  • cardinal - collaborative effort for clinical study reporting
  • cardinal - harmonize TLGs for clinical study reporting

@StefanThoma
Copy link
Collaborator

@bms63 should we just merge it in? It's an older post, so making the title spicier probably won't do much.

@bms63
Copy link
Collaborator

bms63 commented Oct 24, 2024

@bms63 should we just merge it in? It's an older post, so making the title spicier probably won't do much.

He who controls the spice controls the universe

Sounds good please merge in

@StefanThoma
Copy link
Collaborator

Let's go!
dune

@StefanThoma StefanThoma merged commit e110423 into main Oct 24, 2024
5 checks passed
@StefanThoma StefanThoma deleted the 189_update_falcon branch October 24, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants