-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #189 #236
Closes #189 #236
Conversation
not sure what happens with the 'links failing'...it seems to come from other posts, which I didn't touch... |
Looks like the following links from other blogposts fail: Errors in posts/2024-08-15_top_five_pharmaverse_packages/top-five-packages.md
Errors in posts/2024-07-24_working__groups_.../working__groups__updates.md
Errors in posts/2023-08-14_rhino_submission_2/rhino_submission_2.md
I cannot access them either. |
Sadly things just break and urls don't re-direct. If you can't easily find replacements then we can just let the links go through and see if they get fixed/fixed ourselves later. |
Links should get fixed in #238 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good as an update.
Generally, we suggest using the link package to add links to package mentions, but as this is an update to an existing post it is fine as is.
Also, consider renaming the falcon.qmd file to cardinal.qmd.
But I'll leave this up to you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@bms63 can you approve this as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you change qmd file to cardinal.
Is this going to be a package or more of catalog of TLFs?? If going to be package - any timelines on going to CRAN/already on CRAN?
Could we make the title a little more spicier?
- cardinal - collaborative effort to harmonize TLGs for clinical study reporting
- cardinal - collaborative effort for clinical study reporting
- cardinal - harmonize TLGs for clinical study reporting
@bms63 should we just merge it in? It's an older post, so making the title spicier probably won't do much. |
He who controls the spice controls the universe Sounds good please merge in |
Thank you for your Pull Request! We have developed this task checklist to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your blog post.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
main
branch until you have checked off each task."posts/zzz_DO_NOT_EDIT_<your post title>"
. This is so that the post date can be auto-updated upon the merge intomain
.CICD.R
line by line to first check the spelling in your post and then to make sure your code is compatible with our code-style. Address any incongruences by following the instructions in the file!tag(s)
or categories from the current list:c("Metadata", "SDTM", "ADaM", "TLG", "Shiny", "Community", "Conferences", "Submissions", "Technical")
for your blog post. If you cannot find anything that fits your blog post, propose a new tag to the maintainers! Note: if you use a tag not from this list, the "Check Post Tags" CICD pipeline will error. We occasionally tidy up alltags
for consistency.description
field at the top of the markdown document.This blog contains opinions that are of the authors alone and do not necessarily reflect the strategy of their respective organizations.)