-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{sdtm.oak} blog. #244
{sdtm.oak} blog. #244
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice article @rammprasad - thanks for preparing! Some minor comments here from me. The article could also possibly benefit from a visual, e.g. maybe one of the slides you used before that helps understand the modular / algorithm based strategy, or an extract from CDISC COSA site (and the link) to show how people could still get involved in this ongoing effort?
Thank you, @rossfarrugia - I have addressed all review comments and it is ready for re-review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on the package and the post!
I left some comments :)
Thanks Ram! Will leave it to the others to approve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great post @rammprasad !
Left some comments.
|
||
Key Points: | ||
- Algorithms can be re-used across multiple SDTM domains. | ||
- Programming language agnostic: This concept does not rely on a specific programming language for implementation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: StefanThoma <[email protected]> Co-authored-by: Edoardo Mancini <[email protected]>
@manciniedoardo @StefanThoma - I have addressed all the comments. I really appreciate you taking the time to review the blog thoroughly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rammprasad for the updates, looks good now. I've just updated the logo image to a png with slightly larger borders to ensure it renders nicely in the blog home page. I also removed curly brackets ({dplyr} -> dplyr) in one of your section headers as that causes the header to render incorrectly due to a bug in the link package.
Looks good to me too! Thanks for taking care of the comments so swiftly. |
@rammprasad merged and live! feel free to publicise and we'll re-share :) |
Thank you for your Pull Request! We have developed this task checklist to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your blog post.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
main
branch until you have checked off each task."posts/zzz_DO_NOT_EDIT_<your post title>"
. This is so that the post date can be auto-updated upon the merge intomain
.CICD.R
line by line to first check the spelling in your post and then to make sure your code is compatible with our code-style. Address any incongruences by following the instructions in the file!tag(s)
or categories from the current list:c("Metadata", "SDTM", "ADaM", "TLG", "Shiny", "Community", "Conferences", "Submissions", "Technical")
for your blog post. If you cannot find anything that fits your blog post, propose a new tag to the maintainers! Note: if you use a tag not from this list, the "Check Post Tags" CICD pipeline will error. We occasionally tidy up alltags
for consistency.description
field at the top of the markdown document.This blog contains opinions that are of the authors alone and do not necessarily reflect the strategy of their respective organizations.)