Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{sdtm.oak} blog. #244

Merged
merged 15 commits into from
Oct 24, 2024
Merged

{sdtm.oak} blog. #244

merged 15 commits into from
Oct 24, 2024

Conversation

rammprasad
Copy link
Collaborator

@rammprasad rammprasad commented Oct 22, 2024

Thank you for your Pull Request! We have developed this task checklist to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your blog post.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

  • Place Closes Blog Post: sdtm.oak blog once open source #163 into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update), and make sure the corresponding issue is linked in the Development section on the right hand side
  • Ensure your new post folder is of the form "posts/zzz_DO_NOT_EDIT_<your post title>". This is so that the post date can be auto-updated upon the merge into main.
  • Run the script from CICD.R line by line to first check the spelling in your post and then to make sure your code is compatible with our code-style. Address any incongruences by following the instructions in the file!
  • Choose (possibly several) tag(s) or categories from the current list: c("Metadata", "SDTM", "ADaM", "TLG", "Shiny", "Community", "Conferences", "Submissions", "Technical") for your blog post. If you cannot find anything that fits your blog post, propose a new tag to the maintainers! Note: if you use a tag not from this list, the "Check Post Tags" CICD pipeline will error. We occasionally tidy up all tags for consistency.
  • Add a short description for your blog post in the description field at the top of the markdown document.
  • Blog post is short, personalized, reproducible and readable
  • Add a disclaimer at the top of your post, if appropriate (example: Disclaimer
    This blog contains opinions that are of the authors alone and do not necessarily reflect the strategy of their respective organizations.)
  • Address all merge conflicts and resolve appropriately
  • Assign two of us (@bms63, @manciniedoardo, @StefanThoma, @kaz462) as reviewers in the PR.
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

@rammprasad rammprasad linked an issue Oct 22, 2024 that may be closed by this pull request
Copy link
Contributor

@rossfarrugia rossfarrugia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice article @rammprasad - thanks for preparing! Some minor comments here from me. The article could also possibly benefit from a visual, e.g. maybe one of the slides you used before that helps understand the modular / algorithm based strategy, or an extract from CDISC COSA site (and the link) to show how people could still get involved in this ongoing effort?

@rammprasad
Copy link
Collaborator Author

Thank you, @rossfarrugia - I have addressed all review comments and it is ready for re-review.

Copy link
Collaborator

@StefanThoma StefanThoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on the package and the post!
I left some comments :)

@rossfarrugia
Copy link
Contributor

Thank you, @rossfarrugia - I have addressed all review comments and it is ready for re-review.

Thanks Ram! Will leave it to the others to approve.

Copy link
Collaborator

@manciniedoardo manciniedoardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great post @rammprasad !

Left some comments.


Key Points:
- Algorithms can be re-used across multiple SDTM domains.
- Programming language agnostic: This concept does not rely on a specific programming language for implementation.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might also need to use "*" and a double-space indent to get the bullet points to render correctly.

image

@rammprasad
Copy link
Collaborator Author

rammprasad commented Oct 23, 2024

@manciniedoardo @StefanThoma - I have addressed all the comments. I really appreciate you taking the time to review the blog thoroughly.

Copy link
Collaborator

@manciniedoardo manciniedoardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rammprasad for the updates, looks good now. I've just updated the logo image to a png with slightly larger borders to ensure it renders nicely in the blog home page. I also removed curly brackets ({dplyr} -> dplyr) in one of your section headers as that causes the header to render incorrectly due to a bug in the link package.

@StefanThoma
Copy link
Collaborator

Looks good to me too! Thanks for taking care of the comments so swiftly.

@StefanThoma StefanThoma self-requested a review October 24, 2024 07:52
@manciniedoardo manciniedoardo merged commit 40a2a41 into main Oct 24, 2024
5 checks passed
@manciniedoardo manciniedoardo deleted the 163-blog-sdtmoak branch October 24, 2024 07:54
@manciniedoardo
Copy link
Collaborator

@rammprasad merged and live! feel free to publicise and we'll re-share :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blog Post: sdtm.oak blog once open source
4 participants