Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#37_cross_industry_dev #39

Merged
merged 10 commits into from
Aug 3, 2023
Merged

#37_cross_industry_dev #39

merged 10 commits into from
Aug 3, 2023

Conversation

StefanThoma
Copy link
Collaborator

cross company development

@StefanThoma StefanThoma changed the title draft post: #37_cross_industry_dev Jul 27, 2023
@StefanThoma StefanThoma marked this pull request as ready for review July 27, 2023 10:15
@StefanThoma StefanThoma requested review from bms63 and kaz462 July 27, 2023 10:15
@StefanThoma
Copy link
Collaborator Author

Please feel free to rephrase and fix errors or to amend things you find important that I may have left out.

@bms63
Copy link
Collaborator

bms63 commented Jul 30, 2023

Can you shrink this hex done a little bit?

image

@bms63
Copy link
Collaborator

bms63 commented Jul 30, 2023

Can you make this a link
image

@bms63
Copy link
Collaborator

bms63 commented Jul 30, 2023

Is this waiting on another post - could we just link it to phuse or R/Pharma post?

image

@bms63
Copy link
Collaborator

bms63 commented Jul 30, 2023

Could this be linked as well. Licensing is always an interesting topic for folks

image

@bms63
Copy link
Collaborator

bms63 commented Jul 30, 2023

typo and not understanding this sentence
image

@bms63
Copy link
Collaborator

bms63 commented Jul 30, 2023

Really well-written post!!

What about a few images embedded in the post to help break up and highlight keys points in your sections ??- I like the project board graphic in your talk, which could highlight some of our tools that we use for development. Also library(admiral) might be kind of cool to see, like how you have it in your talk!?!

@StefanThoma
Copy link
Collaborator Author

Is this waiting on another post - could we just link it to phuse or R/Pharma post?

image

Yes, I am waiting for this one: #67 but I think I should replace it with something and then link later.

@StefanThoma
Copy link
Collaborator Author

@bms63
Thanks for the thorough review!
I implemented all suggestions.

bms63
bms63 approved these changes Aug 2, 2023
View reviewed changes
Copy link
Collaborator

@bms63 bms63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome!!

kaz462
kaz462 approved these changes Aug 2, 2023
View reviewed changes
Copy link
Collaborator

@kaz462 kaz462 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great post! thanks for sharing your slides from R/Basel 2023 :)
I threw the content into Grammarly and found two minor typos. otherwise, looks pretty good!

posts/2023-07-20_cross_company_dev/cross_industry_dev.qmd Outdated Show resolved Hide resolved
posts/2023-07-20_cross_company_dev/cross_industry_dev.qmd Outdated Show resolved Hide resolved
inst/WORDLIST.txt Outdated Show resolved Hide resolved
@StefanThoma StefanThoma merged commit ecfdfb3 into main Aug 3, 2023
4 checks passed
@StefanThoma StefanThoma deleted the 37_cross_company_development branch August 3, 2023 08:31
@rossfarrugia
Copy link
Contributor

@StefanThoma really nice blog - sorry i'm late with review comments

@StefanThoma StefanThoma restored the 37_cross_company_development branch August 3, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossfarrugia rossfarrugia rossfarrugia left review comments

@kaz462 kaz462 kaz462 approved these changes

@bms63 bms63 bms63 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@StefanThoma @bms63 @rossfarrugia @kaz462