-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
66 pharmaverse story #87
Conversation
@nicholaswe can you use the |
@bms63, just updated the wordlist ;) |
On second thought...this paragraph references 2018 and then references Stefan and Isabella's posts from 2023 feels disjointed. Looking over the article, we go from 2020, to 2022 to 2018 and then references posts written in 2023. Is there anyway to update these paragraphs to be more linear in time? I love all this information here and apologies to be nitpicky, but I felt a bit confused. Might also be an opportunity to plug 2023 R/Pharam at Posit Con as well? |
As a reader not familiar with these packages - it would be interesting to understand what they do briefly. You refence that admiral is for building ADaMs in the next paragraph, so I think it is okay to mention that metacore is for manipulating metadata for ADaMs/SDTMs, xportr is to build submission compliant xpts and logrx is to build logs R scripts. The Stackhouse Report phrase also feels disjointed. Perhpas just say "In 2020, Mike Stackhouse (Atorus) and Michael Rimler (GSK) formed a partnership to build... Missing closing parentheses at the end of the paragraph. |
Nicely done @nicholaswe !! Appreciate you pulling some of the history together for us!! |
Hello, @bms63! Thanks a lot for your suggestions, they were really valuable and made the post better! Unfortunately, I couldn't find a way to reorder the paragraphs/sentences to make the dates more linear, so I added section titles in the post to break the text and force a division between dates. Sorry for that, I couldn't think of a new layout for the ideas. But if you have any suggestions, please, let me know and we can discuss that. My mind is so used to the current text format that it's hard to think outside the box :/ Also, I didn't know how to mention/include R/Pharma 2023 in a natural way. Maybe we can add a section "Got interested?" and explain how people can find more information about pharmaverse and the next events? My only concern is that this will make the text temporal. Thanks one more time! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intriguing post! Thank you so much!
inst/WORDLIST.txt
Outdated
Tplyr | ||
Velásquez's | ||
youtube | ||
======= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this from merge conflicts? I think it should be removed.
|
||
Pharmaverse: from motivation to present | ||
|
||
**Human history and pharmaverse context** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for titles we should use the title markdown to keep it consistent.
Please use:
# Human history and pharmaverse context
Or
## Human history and pharmaverse context
They are the founders of [pharmaverse](https://pharmaverse.org/), members of its Council and kindly shared their memories of how independent companies, in mid-2020, worked together in the creation of a set of packages developed to support the clinical reporting pipeline. | ||
|
||
If you are not familiar with this pipeline, the important thing to know is that, in a nutshell, pharmaceutical companies must follow a bunch of standardized procedures and formats (from Clinical Data Interchange Standards Consortium, [CDISC](https://www.cdisc.org/)) when submitting clinical results to Health Authorities. | ||
Focus on this: **different** companies seeking the **same** standards for outputs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence looks a bit like a note to yourself.
Maybe write:
The focus is on this: different companies ...
**Clinical reporting outputs** | ||
|
||
Rationally, we can say that companies face the same challenges in these steps of the process. | ||
Irrationally, we can also say they were working in silos on that before 2018. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if I understand how saying this is irrational.
Thanks for all the great updates!! It is much easier flow-wise. My last request is that we use everyone's full name - e.g. you use Rimler, Michael and Michael Rimler at different places. I think all names should just be full names, e.g. Michael Rimler (GSK) with company in parenthesis. I think this will read a little better and make it sound less informal. Thanks again. Please see Stefan's PRs requests again and we can wrap this up!! |
Co-authored-by: StefanThoma <[email protected]>
Hello, @bms63, @rossfarrugia and @StefanThoma. Thank you very much for all your suggestions, they have been fully implemented in the text and have made it more enjoyable to read. :) I think now we are ready to go! I hope it will stimulate the curiosity of people outside the community on the subject. Thanks. |
Hello, @bms63 and @StefanThoma!
Sorry for taking so much time to finish this, but now I think I have a final version of the "Pharmaverse (hi)story" post.
I've been talking with some of the guys from pharmaverse council and basically wrote their reports in this post with my own words and understanding of the facts.
As I didn't know when it would be published, I used a dummy date to create the folder on "post" directory, so we can change that.
Finally, I'll send a .doc file with the same text (excluding hyperlinks) to the people I mentioned just to make sure we are publishing the right history and to see if they think we need to add something.
Thanks!