Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closes #76 fix adsl bugs #79

Merged
merged 3 commits into from
Oct 29, 2024
Merged

closes #76 fix adsl bugs #79

merged 3 commits into from
Oct 29, 2024

Conversation

rossfarrugia
Copy link
Contributor

@rossfarrugia rossfarrugia commented Sep 23, 2024

Pull Request

Fix some minor ADSL bugs spotted by Stefan

Before you submit your pull request, take a look at the following checklist. Many thanks for your contribution!

  • Title: Place Closes #<insert_issue_number> at the beginning of your PR title. Use the Edit button in the top-right if you need to update.
  • Linked Issue: Ensure the related issue is linked in the "Development Section" on the right-hand side.
  • First Contribution: If this is your first contribution, add yourself to the DESCRIPTION file.
  • Impact on Examples: If your updates impact any examples, review locally for warnings or errors in the impacted example pages.
  • Merge Conflicts: Developers should address any merge conflicts and merge upon successful review.
  • New Packages: If new packages were used, ensure they are included in the DESCRIPTION file's Imports section.
  • Updated Examples: If you added or updated an example, ensure it runs on the latest CRAN release versions of all packages used.
  • Testing Instructions: Provide instructions on how to test the code if necessary.

@rossfarrugia rossfarrugia linked an issue Sep 23, 2024 that may be closed by this pull request
Copy link
Collaborator

@bundfussr bundfussr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates look good to me.

I've added just a very minor comment and I wonder if the files should be run through styler::style_file().

adam/adsl.R Outdated Show resolved Hide resolved
@bms63
Copy link
Collaborator

bms63 commented Oct 28, 2024

Updates look good to me.

I've added just a very minor comment and I wonder if the files should be run through styler::style_file().

Since we are building up more of a code base - I propose we set up styling and spelling github actions now.

@rossfarrugia
Copy link
Contributor Author

Good idea, I added #82 and will see if anyone wants to take it on.

@bundfussr
Copy link
Collaborator

@rossfarrugia , I've approved the PR but it is still blocked because I don't have write access to the repo.

@rossfarrugia
Copy link
Contributor Author

@bundfussr now granted

@rossfarrugia rossfarrugia merged commit d4a9cc6 into main Oct 29, 2024
2 checks passed
@rossfarrugia rossfarrugia deleted the 76_fix_adsl branch October 29, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in ADaM ADSL example
3 participants