Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #76 TERMNAME -> TERMCHAR in get_terms #77

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Closes #76 TERMNAME -> TERMCHAR in get_terms #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
373bd25
#76 TERMNAME -> TERMCHAR in get_terms
manciniedoardo Nov 17, 2023
a6d5f66
#76 update to query databases
manciniedoardo Nov 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Package: pharmaversesdtm
Type: Package
Title: Test Data for the Pharmaverse Family of Packages
Version: 0.1.1.9000
Version: 0.1.1.9001
Authors@R: c(
person("Edoardo", "Mancini", email = "[email protected]", role = c("aut", "cre")),
person("Gayatri", "G", role = "aut"),
Expand Down
4 changes: 3 additions & 1 deletion NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

## New Features

Following Vaccine Specific SDTM datasets have been added. (#4)
The following Vaccine Specific SDTM datasets have been added. (#4)

- `ce_vaccine`
- `dm_vaccine`
Expand All @@ -15,6 +15,8 @@ Following Vaccine Specific SDTM datasets have been added. (#4)
- `suppex_vaccine`
- `suppface_vaccine`

- `get_terms()` now expects `TERMCHAR` instead of `TERMNAME` in alignment with [this](https://github.com/pharmaverse/admiral/issues/2186) `{admiral}` issue. (#76)

# pharmaversesdtm 0.1.1

## Documentation
Expand Down
4 changes: 2 additions & 2 deletions R/get_terms.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ get_terms <- function(basket_select,
select_id <- NULL
}
keep_cols <- c(
TERMNAME = "termname",
TERMCHAR = "termchar",
SRCVAR = "termvar",
GRPNAME = "smq_name",
select_id
Expand All @@ -57,7 +57,7 @@ get_terms <- function(basket_select,
select_id <- NULL
}
keep_cols <- c(
TERMNAME = "termname",
TERMCHAR = "termchar",
SRCVAR = "termvar",
GRPNAME = "sdg_name",
select_id
Expand Down
6 changes: 3 additions & 3 deletions data-raw/query_databases.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ library(dplyr)

# Create smq dataset ----
pregsmq <- tribble(
~termname, ~scope,
~termchar, ~scope,
"Achromotrichia congenital", "narrow",
"Craniosynostosis", "narrow",
"Hypophosphatasia", "narrow",
Expand Down Expand Up @@ -36,7 +36,7 @@ pregsmq <- tribble(
)

bilismq <- tribble(
~termname, ~scope,
~termchar, ~scope,
"Bile duct cancer recurrent", "narrow",
"Bile duct cancer recurrent", "broad",
"Bile duct squamous cell carcinoma", "narrow",
Expand Down Expand Up @@ -78,7 +78,7 @@ usethis::use_data(smq_db, overwrite = TRUE)

# Create sdg dataset ----
sdg_db <- tribble(
~termname,
~termchar,
"AMINOSALICYLIC ACID",
"AMINOSALICYLATE CALCIUM",
"AMINOSALICYLATE CALCIUM ALUMINIUM",
Expand Down
Loading