Fix true vacuum at high temperature #161
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #161 +/- ##
==========================================
- Coverage 83.36% 83.32% -0.04%
==========================================
Files 54 54
Lines 18770 18774 +4
Branches 1847 1849 +2
==========================================
- Hits 15647 15643 -4
- Misses 3123 3131 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -2401,6 +2401,12 @@ | |||
| PhasesList[i].id = i; | |||
| } | |||
|
|
|||
| // impose that true vacuum at T = Tthigh has id = 0. | |||
| for (auto &phase : PhasesList) | |||
| if ((phase.T_high == T_high) and | |||
Check notice
Code scanning / CodeQL
Equality test on floating-point values Note
vollous
requested review from
phbasler,
lisabiermann and
JonasMueller1991
as code owners
| for (auto &phase : PhasesList) | ||
| if ((phase.T_high == T_high) and | ||
| (phase.Get(T_high).potential < PhasesList[0].Get(T_high).potential)) | ||
| std::swap(PhasesList[0], phase); |
There was a problem hiding this comment.
Are you sure this works? You are swapping an iterator with a reference here.
Maybe use an iterator based for loop and use iterator_swap
There was a problem hiding this comment.
Or maybe easier:
You could use min_element with a compare function to get the position of the required element and then use iterator_swap just once.
With this there would only be one swap
In some models, the BSMPT v2 global minimum does not find the global minimum, just non-global. We added a check to make sure that we always start from the true vacuum.