Use more secure default for RelatedFilter.queryset #146
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The secure default here is to simply remove the current default handling for the
queryset
argument. The underlying form field will complain about the lack of aqueryset
if it's not provided, so this forces the user to explicitly add it to the filter instance.Ref #100. This is only a partial fix, as this only restricts the displayed choices for the relationship. This does not prevent against joins that might leak data.
This is a breaking change.