Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more secure default for RelatedFilter.queryset #146

Merged
merged 5 commits into from
Nov 18, 2016

Conversation

rpkilby
Copy link
Collaborator

@rpkilby rpkilby commented Nov 18, 2016

The secure default here is to simply remove the current default handling for the queryset argument. The underlying form field will complain about the lack of a queryset if it's not provided, so this forces the user to explicitly add it to the filter instance.

Ref #100. This is only a partial fix, as this only restricts the displayed choices for the relationship. This does not prevent against joins that might leak data.

This is a breaking change.

@rpkilby rpkilby added this to the v1.0.0 milestone Nov 18, 2016
@codecov-io
Copy link

codecov-io commented Nov 18, 2016

Current coverage is 97.73% (diff: 100%)

Merging #146 into master will increase coverage by 0.89%

@@             master       #146   diff @@
==========================================
  Files             6          6          
  Lines           222        221     -1   
  Methods           0          0          
  Messages          0          0          
  Branches         45         44     -1   
==========================================
+ Hits            215        216     +1   
+ Misses            3          2     -1   
+ Partials          4          3     -1   

Powered by Codecov. Last update ebb03cf...4126826

@rpkilby rpkilby merged commit 86ebf5d into philipn:master Nov 18, 2016
@rpkilby rpkilby deleted the secure-qs-default branch November 18, 2016 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants