Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test related to-many behavior #219

Merged
merged 2 commits into from
Jan 13, 2018
Merged

Test related to-many behavior #219

merged 2 commits into from
Jan 13, 2018

Conversation

rpkilby
Copy link
Collaborator

@rpkilby rpkilby commented Jan 12, 2018

Add tests for filtering across to-many relationships. Includes:

  • A few tests for filtering across to-many relationships w/ filtersets. Note that these are currently expected failures, and will be fixed with the related filtering rework.
  • Tests that describe assumptions about the behavior of filtering across to-many relationships. These are used to help validate the expected behavior of filtersets.

ref #217

@codecov-io
Copy link

codecov-io commented Jan 12, 2018

Codecov Report

Merging #219 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #219   +/-   ##
=======================================
  Coverage   97.98%   97.98%           
=======================================
  Files           4        4           
  Lines         248      248           
  Branches       53       53           
=======================================
  Hits          243      243           
  Misses          1        1           
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0168b06...964cd69. Read the comment docs.

@rpkilby
Copy link
Collaborator Author

rpkilby commented Jan 13, 2018

The tests can probably be improved, but I think it's Good EnoughTM for now.

@rpkilby rpkilby merged commit 6106bb7 into philipn:master Jan 13, 2018
@rpkilby rpkilby deleted the assumptions branch January 13, 2018 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants