Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imxrt-multi: Implement i2c driver #491

Merged
merged 3 commits into from
Jul 19, 2024
Merged

imxrt-multi: Implement i2c driver #491

merged 3 commits into from
Jul 19, 2024

Conversation

gerard5
Copy link
Contributor

@gerard5 gerard5 commented May 8, 2024 •
edited by Darchiv
Loading

Work in progress

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

github-actions[bot]
github-actions bot reviewed May 8, 2024
View reviewed changes
multi/imxrt-multi/i2c.c Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024 •
edited
Loading

Unit Test Results

7 460 tests   6 745 ✅  37m 0s ⏱️
  420 suites    715 💤
    1 files        0 ❌

Results for commit 3bc1b98.

♻️ This comment has been updated with latest results.

@gerard5 gerard5 self-assigned this May 8, 2024
@jmaksymowicz jmaksymowicz force-pushed the gerard5/NIL-453 branch 4 times, most recently from 642f41f to 574a5a8 Compare July 9, 2024 12:59
@gerard5 @jmaksymowicz
imxrt-multi: add trace helper
c544675 
JIRA: NIL-453
@gerard5 @jmaksymowicz
imxrt-multi: implement i2c driver
a6a2387 
Implement i2c driver using i2c-common api.

JIRA: NIL-453
@jmaksymowicz jmaksymowicz marked this pull request as ready for review July 10, 2024 09:21
@Darchiv Darchiv changed the title imxrt-multi i2c imxrt-multi: Implement i2c driver Jul 19, 2024
Darchiv
Darchiv reviewed Jul 19, 2024
View reviewed changes
multi/imxrt-multi/imxrt-multi.c Outdated Show resolved Hide resolved
multi/imxrt-multi/imxrt-multi.c Show resolved Hide resolved
multi/imxrt-multi/i2c.c Outdated Show resolved Hide resolved
multi/imxrt-multi/i2c.c Show resolved Hide resolved
@Darchiv Darchiv assigned jmaksymowicz and unassigned gerard5 Jul 19, 2024
@jmaksymowicz
imxrt-multi: implement I2C driver
3bc1b98 
Add pin mux setup
Add clock timing setup
Add functions for read/write

JIRA: NIL-453
@Darchiv Darchiv merged commit 7a8e1b9 into master Jul 19, 2024
30 checks passed
@Darchiv Darchiv deleted the gerard5/NIL-453 branch July 19, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmaksymowicz jmaksymowicz jmaksymowicz left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

@Darchiv Darchiv Darchiv approved these changes

Assignees

@jmaksymowicz jmaksymowicz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gerard5 @Darchiv @jmaksymowicz