imxrt-flash: support for calulating CRC32 of selected region #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ziemleszcz
force-pushed
the
ziemleszcz/NIL-574
branch
from
70f7bee
to
202e123
Compare
JIRA: NIL-574
ziemleszcz
force-pushed
the
ziemleszcz/NIL-574
branch
2 times, most recently
from
d012992
to
ebb4991
Compare
ziemleszcz
force-pushed
the
ziemleszcz/NIL-574
branch
from
ebb4991
to
997d217
Compare
gerard5
reviewed
May 17, 2024
storage/imxrt-flash/flashsrv.c
Outdated
| return res; | ||
| } | ||
|
|
||
| buf = malloc(CRC32_BUFSZ); |
There was a problem hiding this comment.
The imxrt-flash is a legally relevant part of fw. All allocated memory should be known at initialization stage or compile time. Using malloc/free at each call to function may lead to memory fragmentation during long-term operation (MISRA Dir 4.12 req.).
Btw. NOR page size is 256 bytes @ 4KiB sector size, you can use smaller buffer for it e.g. of page size 256 bytes if allocated statically to save ram space.
ziemleszcz
force-pushed
the
ziemleszcz/NIL-574
branch
from
997d217
to
5e30166
Compare
CRC32 can be calulated for selected region of flash memory or raw partition. To calculate automatically CRC32 of whole memory/partition set addr and len to 0. JIRA: NIL-574
ziemleszcz
force-pushed
the
ziemleszcz/NIL-574
branch
from
5e30166
to
0bf50dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CRC32 can be calulated for selected region of flash memory or raw partition. To calculate automatically CRC32 of whole memory/partition set addr and len to 0.
JIRA: NIL-574
Description
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment