pc-tty: add framebuffer-based console #515
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
adamgreloch
force-pushed
the
adamgreloch/RTOS-925
branch
from
35702e8
to
2654383
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
adamgreloch
force-pushed
the
adamgreloch/RTOS-925
branch
from
2654383
to
548f3f7
Compare
adamgreloch
force-pushed
the
adamgreloch/RTOS-925
branch
3 times, most recently
from
6d0bbae
to
1370274
Compare
adamgreloch
force-pushed
the
adamgreloch/RTOS-925
branch
2 times, most recently
from
c8fb3ba
to
7a450db
Compare
agkaminski
reviewed
Oct 21, 2024
adamgreloch
force-pushed
the
adamgreloch/RTOS-925
branch
from
7a450db
to
be2c3eb
Compare
agkaminski
reviewed
Oct 29, 2024
tty/pc-tty/ttypc_fbcon.c
Outdated
| static void _drawPixel(ttypc_vt_t *vt, uint16_t x, uint16_t y, uint32_t color) | ||
| { | ||
| ttypc_t *ttypc = vt->ttypc; | ||
| *(volatile uint32_t *)((addr_t)ttypc->fbaddr + (x * (ttypc->fbbpp / 8U)) + (y * ttypc->fbpitch)) = color; |
There was a problem hiding this comment.
addr_t is reserved for physical addresses. Use uintptr_t or, even better, char *
There was a problem hiding this comment.
Changed to uintptr_t for now. What's the idea behind char *?
Adds a graphics mode console that prints terminal output in 8x16 font to a linear framebuffer located under address queried via platformctl/pctl_graphmode in a 80x25 terminal resolution. This implementation assumes ARGB ordering of the framebuffer JIRA: RTOS-925
Graphical apps can now disable console drawing via ioctl/TTYSETMODE to ensure uninterrupted drawing (otherwise app and console would draw to the framebuffer in the same time, causing mess) JIRA: RTOS-925
Current vt will now automatically resize from 80x25 to the maximum resolution supported by current graphic mode if fbcon is enabled (i.e. for 1280x800 and 8x16 font it will resize to 160x50) JIRA: RTOS-925
Since the _ttypc_vga_{set,read,write,move} have the ttypc_vt_t already
passed, they can retrieve the vga pointer from that struct. This also
makes the API more secure in case of fbcon, which implicitly assumed
vga == vt->vram when calculating char positions. Now this assumption is
guaranteed
JIRA: RTOS-925
adamgreloch
force-pushed
the
adamgreloch/RTOS-925
branch
from
be2c3eb
to
25efa68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a graphics mode console that prints terminal output in 8x16 font to a linear framebuffer located under address queried via platformctl/pctl_graphmode in a maximum resolution supported by current graphic mode
This implementation assumes ARGB ordering of the framebuffer
JIRA: RTOS-925
Description
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment
cmd: add vbe modesetting command plo#352
phoenix: add fbcon ioctls libphoenix#386