Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imxrt-flash: add optional "bank" detection on startup #519

Merged
merged 1 commit into from
Oct 17, 2024
Merged

imxrt-flash: add optional "bank" detection on startup #519

merged 1 commit into from
Oct 17, 2024

Conversation

nalajcie
Copy link
Member

Description

Detect active "bank" (the partition from which the flashsrv was loaded) and create symlink /dev/root to that partition.

Motivation and Context

JIRA: NIL-644

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: NIL

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 16, 2024 •
edited
Loading

Unit Test Results

7 741 tests  ±0   7 026 ✅ ±0   41m 34s ⏱️ +11s
  461 suites ±0     715 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 85a9d10. ± Comparison against base commit 48a5f47.

♻️ This comment has been updated with latest results.

agkaminski
agkaminski reviewed Oct 16, 2024
View reviewed changes
Copy link
Member

@agkaminski agkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicks, otherwise LGTM

storage/imxrt-flash/flashsrv.c Outdated Show resolved Hide resolved
storage/imxrt-flash/flashsrv.c Outdated Show resolved Hide resolved
@nalajcie
imxrt-flash: add optional "bank" detection on startup
85a9d10 
Detect active "bank" (the partition from which the flashsrv was loaded)
and create symlink `/dev/root` to that partition.

JIRA: NIL-644
@nalajcie nalajcie merged commit 3f95398 into master Oct 17, 2024
36 checks passed
@nalajcie nalajcie deleted the nalajcie/imxrt_bank branch October 17, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agkaminski agkaminski agkaminski approved these changes

@Darchiv Darchiv Awaiting requested review from Darchiv

@anglov anglov Awaiting requested review from anglov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nalajcie @agkaminski