Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST BRANCH #135

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

TEST BRANCH #135

wants to merge 1 commit into from

Conversation

adamdebek
Copy link

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

Copy link

github-actions bot commented Aug 22, 2024

Unit Test Results

7 700 tests  ±0   6 985 ✅ ±0   37m 37s ⏱️ - 1m 18s
  436 suites ±0     715 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit c0a1fca. ± Comparison against base commit ac000e1.

♻️ This comment has been updated with latest results.

@adamdebek adamdebek force-pushed the adamdebek/nightly_test branch 3 times, most recently from 67637a8 to e77c16f Compare August 26, 2024 12:31
jffs2/dir.c Outdated Show resolved Hide resolved
@adamdebek adamdebek force-pushed the adamdebek/nightly_test branch 4 times, most recently from 054de31 to 08a19a1 Compare August 26, 2024 12:44
@adamdebek adamdebek closed this Aug 26, 2024
@adamdebek adamdebek reopened this Aug 26, 2024
@adamdebek adamdebek force-pushed the adamdebek/nightly_test branch 8 times, most recently from 6ee9f00 to c0973f5 Compare August 29, 2024 09:49
ret = jffs2_garbage_collect_dirent(c, jeb, f, fd);
} else if (fd) {
} else if (fd && !f->drefs) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[clang-format-pr] reported by reviewdog 🐶
suggested fix

Suggested change
} else if (fd && !f->drefs) {
}
else if (fd && !f->drefs) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant