Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix occasional triple-faults on ia32 #532

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Fix occasional triple-faults on ia32 #532

merged 2 commits into from
Apr 4, 2024

Conversation

agkaminski
Copy link
Member

Description

Motivation and Context

Fixes phoenix-rtos/phoenix-rtos-project#1012

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (ia32-generic-qemu).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@agkaminski
process: Fix potential races on kstack change (vfork)
b1cf027 
JIRA: RTOS-806
@agkaminski
ia32: Increase KSTACK size
2080a76 
Fix occasional tripple faults caused by kstack overflow

DONE: RTOS-806
@agkaminski agkaminski changed the title Agkaminski/rtos 806 Fix occasional triple-faults on ia32 Mar 29, 2024
@github-actions GitHub Actions
Copy link

Unit Test Results

7 284 tests  ±0   6 569 ✅ ±0   38m 4s ⏱️ +7s
  409 suites ±0     715 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 2080a76. ± Comparison against base commit e403035.

lukileczo
lukileczo approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@lukileczo lukileczo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agkaminski agkaminski merged commit 7eed738 into master Apr 4, 2024
30 checks passed
@agkaminski agkaminski deleted the agkaminski/rtos-806 branch April 4, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukileczo lukileczo lukileczo approved these changes

@gerard5 gerard5 Awaiting requested review from gerard5

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ia32-generic-qemu: intermittent system reboots during fork() and exit
2 participants
@agkaminski @lukileczo