Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

riscv64/Makefile: disable gp relaxations #588

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Conversation

badochov
Copy link
Contributor

@badochov badochov commented Sep 10, 2024

binutils 2.41 silently introduced gp relaxations which for some reason make kernel impossible to build
JIRA: RTOS-912

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

Copy link

github-actions bot commented Sep 10, 2024

Unit Test Results

7 723 tests  ±0   7 008 ✅ ±0   37m 9s ⏱️ +12s
  443 suites ±0     715 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit cd99881. ± Comparison against base commit cb7fddd.

♻️ This comment has been updated with latest results.

@badochov badochov force-pushed the badochov/binutils-2.43 branch 3 times, most recently from ad71c60 to a8bc834 Compare September 11, 2024 08:52
@badochov badochov force-pushed the badochov/binutils-2.43 branch 2 times, most recently from 1ff04e9 to 7fe40a6 Compare September 17, 2024 14:01
@badochov badochov force-pushed the badochov/binutils-2.43 branch 2 times, most recently from 078155a to df6b811 Compare September 23, 2024 16:09
@badochov badochov mentioned this pull request Sep 24, 2024
14 tasks
@badochov badochov force-pushed the badochov/binutils-2.43 branch 2 times, most recently from 7dfd32c to 4a6a81f Compare September 30, 2024 09:42
@Darchiv
Copy link
Member

Darchiv commented Oct 2, 2024

Please add a (short) description of this change (+why it is needed), so that no one has to dive into commit section.

@badochov
Copy link
Contributor Author

badochov commented Oct 2, 2024

Please add a (short) description of this change (+why it is needed), so that no one has to dive into commit section.

done

binutils 2.41 silently introduced gp relaxations which for some reason make kernel impossible to build.

JIRA: RTOS-912
@badochov badochov merged commit a1a6787 into master Oct 2, 2024
34 checks passed
@badochov badochov deleted the badochov/binutils-2.43 branch October 2, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants