Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syscalls: enable getting functions from stack #607

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

badochov
Copy link
Contributor

@badochov badochov commented Oct 11, 2024

DONE: RTOS-947

Description

Adjust GETFROMSTACK to enable passing functions as type.

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@badochov
Copy link
Contributor Author

After this change type argument is no longer needed, moreover, easily we can get rid of n argument of GETFROMTYPE. However, I see readability improvement in letting them stay.

Copy link

github-actions bot commented Oct 11, 2024

Unit Test Results

7 741 tests  +16   7 026 ✅ +16   39m 34s ⏱️ + 2m 22s
  461 suites +16     715 💤 ± 0 
    1 files   ± 0       0 ❌ ± 0 

Results for commit 33991ac. ± Comparison against base commit 8a3ee95.

♻️ This comment has been updated with latest results.

@badochov badochov force-pushed the badochov/getfromstack branch 2 times, most recently from 3a136b3 to 7788743 Compare October 11, 2024 19:51
@badochov badochov requested a review from Darchiv October 11, 2024 19:52
@badochov badochov marked this pull request as ready for review October 11, 2024 19:52
@badochov
Copy link
Contributor Author

@Darchiv do you think that we should keep the type argument?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant