add fs_mark harness #233

adamdebek · 2023-07-31T12:05:01Z

JIRA: CI-307

Description

Motivation and Context

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

Already covered by automatic testing.
New test added: (add PR link here).
Tested by hand on: (list targets here).

Checklist:

My change requires a change to the documentation.
I have updated the documentation accordingly.
I have added tests to cover my changes.
All new and existing linter checks and tests passed.
My changes generate no new compilation warnings for any of the targets.

Special treatment

This PR needs additional PRs to work (list the PRs, preferably in merge-order).
I will merge this PR by myself when appropriate.

fs_mark/fs_mark.c

fs_mark/Makefile

fs_mark/fs_mark.c

fs_mark/fs_mark.py

github-actions · 2023-09-04T11:09:48Z

Unit Test Results

6 002 tests ±0 5 361 ✔️ ±0 30m 19s ⏱️ + 1m 49s
  346 suites ±0   641 💤 ±0
      1 files ±0       0 ❌ ±0

Results for commit a6ef2d4. ± Comparison against base commit 99e684d.

♻️ This comment has been updated with latest results.

fs_mark/fs_mark.py

fs_mark/Makefile

fs_mark/fs_mark.py

damianloew · 2023-12-20T17:07:35Z

fs_mark/fs_mark.py

+            return -2
+    else:
+        return 0
+


Let's place there sample output from fs mark like it's done for mbedtls - it will be much easier to analyze the harness then, sth like:

FSUse% Count Size Files/sec App Overhead CREAT (Min/Avg/Max) WRITE (Min/Avg/Max) FSYNC (Min/Avg/Max) SYNC (Min/Avg/Max) CLOSE (Min/Avg/Max) UNLINK (Min/Avg/Max) 27 10 0 71.1 19612 10439 11319 12782 327 384 479 0 0 0 0 0 0 372 396 428 0 0 0 27 20 0 66.1 20880 11356 12248 13971 367 389 407 0 0 0 0 0 0 375 400 438 0 0 0 27 30 0 67.4 18939 11368 12152 13179 371 399 503 0 0 0 0 0 0 377 394 422 0 0 0 27 40 0 53.5 26032 11556 15166 28925 372 450 1014 0 0 0 0 0 0 379 462 954 0 0 0 27 50 0 57.2 23061 12960 14265 18243 375 457 967 0 0 0 0 0 0 383 445 836 0 0 0 27 60 0 60.9 19539 12836 13617 15040 373 406 498 0 0 0 0 0 0 382 436 762 0 0 0 27 70 0 52.8 23458 12563 15690 25471 337 439 807 0 0 0 0 0 0 380 447 810 0 0 0

I tried to add it like in mbedtls but flake8 complain about unused variable

I would still include a sample output, for example, in the form of:
"""
OUTPUT
"""

damianloew · 2023-12-20T19:00:58Z

fs_mark/fs_mark_clean.c

+	while ((ret = rmdir(dirPath)) < 0) {
+		if (errno == ENOTEMPTY && try < 5) {
+			remove_dir_recursive(dirPath);
+			try++;
+		}
+		else if (errno == ENOENT) {
+			errno = 0;
+			return 0;
+		}
+		else {
+			return -1;
+		}


Is it necessary? We can remove dirs also using remove().

But using rmdir() is semantically correct.

damianloew · 2023-12-20T19:02:44Z

fs_mark/test_armv7a7-imx6ull-evk.yaml

+  targets:
+    value: [armv7a7-imx6ull-evk]
+
+# TODO: full fs filling tests


Is it already added?

damianloew · 2023-12-20T19:03:53Z

fs_mark/test_armv7a7-imx6ull-evk.yaml

+    - name: fs_mark_pageSizeFiles_alignedWrite_20_threads
+      execute: fs_mark -d /fs_mark_test -t 20 -D 20 -N 1 -s 4096 -w 32 -n 20 -v -S 0 -L 5
+
+    # s=10000 w=32


to remove (?)

Suggested change

# s=10000 w=32

Same with the other places.

I think it can remain, this comment show how this tests are organized. Full fs filling tests are not added for now due to difficulty of checking how much space is left on jffs2.

damianloew · 2023-12-20T19:05:47Z

fs_mark/test_armv7a7-imx6ull-evk.yaml

+# This yaml contain armv7a7-imx6ull-evk specific fs_mark tests
+test:
+  type: harness
+  harness: fs_mark.py


As we discussed I would consider adding some nested cases to provide better coverage.

This tests are not straight forward to implement, maybe it is better to add it later on.

trunner/harness/psh.py

github-actions · 2023-12-21T17:51:34Z

fs_mark/fs_mark.py

+    loop_time = 1200
+    first_loop_done = False
+
+    # Single line of input (wraped to pass linter)


[codespell] _{reported by reviewdog 🐶}
wraped ==> wrapped, warped

fs_mark/fs_mark.py

JIRA: CI-307

mateusz-bloch · 2024-04-05T11:55:07Z

fs_mark/Makefile

@@ -0,0 +1 @@
+$(eval $(call add_test, fs-mark-clean))


I'm considering whether it might be better to rename the macro, as it's not actually a test after all.. However, we could discuss this during something lika a repository cleanup/organization, not directly here.

mateusz-bloch · 2024-04-05T11:56:02Z

fs_mark/fs_mark.py

@@ -0,0 +1,159 @@
+import trunner


Group imports (standard library, third-party, and local imports)

mateusz-bloch · 2024-04-05T11:57:24Z

fs_mark/fs_mark.py

+
+
+def harness(dut: Dut, ctx: TestContext, result: TestResult):
+    target = trunner.ctx.target.name


Shouldn't ctx.target.name be sufficient? In that case, the import trunner would be unnecessary

mateusz-bloch · 2024-04-05T11:59:35Z

fs_mark/fs_mark.py

+        return 0
+
+
+def harness(dut: Dut, ctx: TestContext, result: TestResult):


you could specify what the function should return ->

mateusz-bloch · 2024-04-05T12:02:19Z

fs_mark/fs_mark.py

+from trunner.types import TestResult, Status
+
+
+def clean(dut, test_name, ctx: TestContext) -> int:


Suggested change

def clean(dut, test_name, ctx: TestContext) -> int:

def clean(dut: Dut, test_name: str, ctx: TestContext) -> int:

mateusz-bloch · 2024-04-05T12:12:29Z

fs_mark/fs_mark.py

+        if idx == 0:
+            return 0
+        elif idx == 1:
+            return -1
+        elif idx == 2:
+            return -2
+


maybe something like:

if idx in [0,1,2]: return -idx

mateusz-bloch · 2024-04-05T12:18:20Z

fs_mark/fs_mark.py

+            return -2
+    else:
+        return 0
+


I would still include a sample output, for example, in the form of:
"""
OUTPUT
"""

mateusz-bloch · 2024-04-05T12:36:18Z

fs_mark/fs-mark-clean.c

+			return 1;
+		}
+		/* Clean test directory */
+		errno = 0;


Why is there errno ?

mateusz-bloch · 2024-04-05T12:42:01Z

fs_mark/fs_mark.py

+                if not t_data.timing_dict[(target, name)][0] <= int(value) <= t_data.timing_dict[(target, name)][1]:
+                    test_status = Status.FAIL
+                    test_msg += ''.join(('\n\t', name, ' exec time - ', value, ' out of range [',
+                                         str(t_data.timing_dict[(
+                                             target, name)][0]), ' - ',
+                                         str(t_data.timing_dict[(target, name)][1]), ']'))


Maybe this approach will be more readable ?:

Suggested change

if not t_data.timing_dict[(target, name)][0] <= int(value) <= t_data.timing_dict[(target, name)][1]:

test_status = Status.FAIL

test_msg += ''.join(('\n\t', name, ' exec time - ', value, ' out of range [',

str(t_data.timing_dict[(

target, name)][0]), ' - ',

str(t_data.timing_dict[(target, name)][1]), ']'))

min_val, max_val = t_data.timing_dict[(target, name)]

if not min_val <= int(value) <= max_val:

test_status = Status.FAIL

test_msg += f"\n\t{name} exec time - {value} out of range [{min_val} - {max_val}]"

mateusz-bloch · 2024-04-05T12:44:13Z

fs_mark/fs_mark.py

+                test_msg += "\n\n\tF_Use%: " + str(f_use)
+                test_msg += "\n\tCount: " + str(count)
+                test_msg += "\n\tSize: " + str(size)
+                test_msg += "\n\tFiles/sec: " + str(files_sec)
+                test_msg += "\n\tApp overhead: " + str(app_overhead) + "\n\t"


What do you think about this? :

Suggested change

test_msg += "\n\n\tF_Use%: " + str(f_use)

test_msg += "\n\tCount: " + str(count)

test_msg += "\n\tSize: " + str(size)

test_msg += "\n\tFiles/sec: " + str(files_sec)

test_msg += "\n\tApp overhead: " + str(app_overhead) + "\n\t"

test_msg += '\n\t'.join((

f"F_Use%: {f_use}",

f"Count: {count}",

f"Size: {size}",

f"Files/sec: {files_sec}",

f"App overhead: {app_overhead}\n\t"

))

mateusz-bloch · 2024-04-05T14:15:43Z

fs_mark/fs_mark.py

+    first_loop_done = False
+
+    NAME = r".+?#  (?P<name>(/bin/)?fs_mark.+?)\r+\n"
+    MSG_LINE = r"(?P<line>(\s+\d+){3}.+?)\r+\n"


Could you clarify whether there have been any issues with regex on any specific target? From my current testing on ia32-generic-qemu, I've managed to capture regex results into groups smoothly, both under no load and under stress. However, I haven't tested this extensively.

My regex:

TYPES = [ "f_use", "count", "size", "files_sec", "app_overhead", "creatMin", "creatAbg", "creatMax", "writeMin", "writeAbg", "writeMax", "fsyncMin", "fsyncAbg", "fsyncMax", "syncMin", "syncAbg", "syncMax", "closeMin", "closeAbg", "closeMax", "unlinkMin", "unlinkAbg", "unlinkMax", ] MSG_LINE = "".join([rf"(?P<{type}>-?\d+\.?\d*)\s+" for type in TYPES]) + r"\r?\n"

Code on which that was tested:

while True: if loop_start and loop_end: loop_time = 3 * (loop_end - loop_start) loop_start = None loop_end = None idx = dut.expect([NAME, MSG_LINE, NO_SPC, END, NO_CONT_BLOCK, ERR], timeout=60) parsed = dut.match.groupdict() print(parsed) if idx == 0: test_name = parsed["name"] loop_start = time.time() elif idx == 1: pass

Output:

�[0J(psh)% /bin/fs_mark -d /fs_mark_test -s 0 -n 10 -v -S 0 -L 10 # /bin/fs_mark -d /fs_mark_test -s 0 -n 10 -v -S 0 -L 10 {'name': '/bin/fs_mark -d /fs_mark_test -s 0 -n 10 -v -S 0 -L 10 '} # Version 3.3, 1 thread(s) starting at Thu Jan 1 00:00:08 1970 # Sync method: NO SYNC: Test does not issue sync() or fsync() calls. # Directories: no subdirectories used # File names: 40 bytes long, (16 initial bytes of time stamp with 24 random bytes at end of name) # Files info: size 0 bytes, written with an IO size of 16384 bytes per write # App overhead is time in microseconds spent in the test not doing file writing related system calls. # All system call times are reported in microseconds. FSUse% Count Size Files/sec App Overhead CREAT (Min/Avg/Max) WRITE (Min/Avg/Max) FSYNC (Min/Avg/Max) SYNC (Min/Avg/Max) CLOSE (Min/Avg/Max) UNLINK (Min/Avg/Max) 27 10 0 1.7 181866 358108 547925 712653 1601 3120 6763 0 0 0 0 0 0 1404 3829 15385 0 0 0 {'f_use': '27', 'count': '10', 'size': '0', 'files_sec': '1.7', 'app_overhead': '181866', 'creatMin': '358108', 'creatAbg': '547925', 'creatMax': '712653', 'writeMin': '1601', 'writeAbg': '3120', 'writeMax': '6763', 'fsyncMin': '0', 'fsyncAbg': '0', 'fsyncMax': '0', 'syncMin': '0', 'syncAbg': '0', 'syncMax': '0', 'closeMin': '1404', 'closeAbg': '3829', 'closeMax': '15385', 'unlinkMin': '0', 'unlinkAbg': '0', 'unlinkMax': '0'} 27 20 0 1.6 237227 419356 590063 842584 1844 3814 7751 0 0 0 0 0 0 1814 4079 9268 0 0 0 27 30 0 1.4 213842 451503 674516 982013 1746 5525 15782 0 0 0 0 0 0 1719 5564 20754 0 0 0 27 40 0 1.5 172467 517018 643414 737076 2138 3036 5709 0 0 0 0 0 0 1981 5020 10241 0 0 0 27 50 0 1.7 156668 501367 577613 700207 2071 3411 6560 0 0 0 0 0 0 1709 2290 3061 0 0 0 28 60 0 1.5 216290 546834 630984 836860 1656 3969 10902 0 0 0 0 0 0 1937 3399 6637 0 0 0 28 70 0 1.5 192122 431973 632832 793497 1250 3366 12533 0 0 0 0 0 0 1438 2688 5080 0 0 0 28 80 0 1.6 139242 479825 622701 775921 1730 4523 10685 0 0 0 0 0 0 1837 3346 9047 0 0 0 {'f_use': '27', 'count': '20', 'size': '0', 'files_sec': '1.6', 'app_overhead': '237227', 'creatMin': '419356', 'creatAbg': '590063', 'creatMax': '842584', 'writeMin': '1844', 'writeAbg': '3814', 'writeMax': '7751', 'fsyncMin': '0', 'fsyncAbg': '0', 'fsyncMax': '0', 'syncMin': '0', 'syncAbg': '0', 'syncMax': '0', 'closeMin': '1814', 'closeAbg': '4079', 'closeMax': '9268', 'unlinkMin': '0', 'unlinkAbg': '0', 'unlinkMax': '0'} {'f_use': '27', 'count': '30', 'size': '0', 'files_sec': '1.4', 'app_overhead': '213842', 'creatMin': '451503', 'creatAbg': '674516', 'creatMax': '982013', 'writeMin': '1746', 'writeAbg': '5525', 'writeMax': '15782', 'fsyncMin': '0', 'fsyncAbg': '0', 'fsyncMax': '0', 'syncMin': '0', 'syncAbg': '0', 'syncMax': '0', 'closeMin': '1719', 'closeAbg': '5564', 'closeMax': '20754', 'unlinkMin': '0', 'unlinkAbg': '0', 'unlinkMax': '0'} {'f_use': '27', 'count': '40', 'size': '0', 'files_sec': '1.5', 'app_overhead': '172467', 'creatMin': '517018', 'creatAbg': '643414', 'creatMax': '737076', 'writeMin': '2138', 'writeAbg': '3036', 'writeMax': '5709', 'fsyncMin': '0', 'fsyncAbg': '0', 'fsyncMax': '0', 'syncMin': '0', 'syncAbg': '0', 'syncMax': '0', 'closeMin': '1981', 'closeAbg': '5020', 'closeMax': '10241', 'unlinkMin': '0', 'unlinkAbg': '0', 'unlinkMax': '0'} {'f_use': '27', 'count': '50', 'size': '0', 'files_sec': '1.7', 'app_overhead': '156668', 'creatMin': '501367', 'creatAbg': '577613', 'creatMax': '700207', 'writeMin': '2071', 'writeAbg': '3411', 'writeMax': '6560', 'fsyncMin': '0', 'fsyncAbg': '0', 'fsyncMax': '0', 'syncMin': '0', 'syncAbg': '0', 'syncMax': '0', 'closeMin': '1709', 'closeAbg': '2290', 'closeMax': '3061', 'unlinkMin': '0', 'unlinkAbg': '0', 'unlinkMax': '0'} {'f_use': '28', 'count': '60', 'size': '0', 'files_sec': '1.5', 'app_overhead': '216290', 'creatMin': '546834', 'creatAbg': '630984', 'creatMax': '836860', 'writeMin': '1656', 'writeAbg': '3969', 'writeMax': '10902', 'fsyncMin': '0', 'fsyncAbg': '0', 'fsyncMax': '0', 'syncMin': '0', 'syncAbg': '0', 'syncMax': '0', 'closeMin': '1937', 'closeAbg': '3399', 'closeMax': '6637', 'unlinkMin': '0', 'unlinkAbg': '0', 'unlinkMax': '0'} {'f_use': '28', 'count': '70', 'size': '0', 'files_sec': '1.5', 'app_overhead': '192122', 'creatMin': '431973', 'creatAbg': '632832', 'creatMax': '793497', 'writeMin': '1250', 'writeAbg': '3366', 'writeMax': '12533', 'fsyncMin': '0', 'fsyncAbg': '0', 'fsyncMax': '0', 'syncMin': '0', 'syncAbg': '0', 'syncMax': '0', 'closeMin': '1438', 'closeAbg': '2688', 'closeMax': '5080', 'unlinkMin': '0', 'unlinkAbg': '0', 'unlinkMax': '0'} {'f_use': '28', 'count': '80', 'size': '0', 'files_sec': '1.6', 'app_overhead': '139242', 'creatMin': '479825', 'creatAbg': '622701', 'creatMax': '775921', 'writeMin': '1730', 'writeAbg': '4523', 'writeMax': '10685', 'fsyncMin': '0', 'fsyncAbg': '0', 'fsyncMax': '0', 'syncMin': '0', 'syncAbg': '0', 'syncMax': '0', 'closeMin': '1837', 'closeAbg': '3346', 'closeMax': '9047', 'unlinkMin': '0', 'unlinkAbg': '0', 'unlinkMax': '0'} 28 90 0 1.5 225379 418652 633652 1053823 1616 3947 18033 0 0 0 0 0 0 2179 4394 10715 0 0 0 {'f_use': '28', 'count': '90', 'size': '0', 'files_sec': '1.5', 'app_overhead': '225379', 'creatMin': '418652', 'creatAbg': '633652', 'creatMax': '1053823', 'writeMin': '1616', 'writeAbg': '3947', 'writeMax': '18033', 'fsyncMin': '0', 'fsyncAbg': '0', 'fsyncMax': '0', 'syncMin': '0', 'syncAbg': '0', 'syncMax': '0', 'closeMin': '2179', 'closeAbg': '4394', 'closeMax': '10715', 'unlinkMin': '0', 'unlinkAbg': '0', 'unlinkMax': '0'} 28 100 0 1.2 226891 477213 774066 1200110 1676 3605 8894 0 0 0 0 0 0 1573 3729 10540 0 0 0 {'f_use': '28', 'count': '100', 'size': '0', 'files_sec': '1.2', 'app_overhead': '226891', 'creatMin': '477213', 'creatAbg': '774066', 'creatMax': '1200110', 'writeMin': '1676', 'writeAbg': '3605', 'writeMax': '8894', 'fsyncMin': '0', 'fsyncAbg': '0', 'fsyncMax': '0', 'syncMin': '0', 'syncAbg': '0', 'syncMax': '0', 'closeMin': '1573', 'closeAbg': '3729', 'closeMax': '10540', 'unlinkMin': '0', 'unlinkAbg': '0', 'unlinkMax': '0'} Average Files/sec: 1.0 {}

The python harness is being run on host - I assume You've been testing the target ia32-generic-qemu on your laptop - which is more capable than GA runner (either from GitHub or our RPi).

Regex expressions are hard on CPU (if you don't construct them carefully you could even have O(2^n) complexity!) - so a rule of thumb is to avoid them if they're not necessary (and better use simple ones when not). Please note that intensive regex matching might impact the test total time being measured (not much, but still).

Current approach with splitting the line is better CPU-wise, could probably still be optimized in regards to python syntax, eg:

TYPES = [ "f_use", "count", "size", "files_sec", "app_overhead", "creatMin", "creatAbg", "creatMax", "writeMin", "writeAbg", "writeMax", "fsyncMin", "fsyncAbg", "fsyncMax", "syncMin", "syncAbg", "syncMax", "closeMin", "closeAbg", "closeMax", "unlinkMin", "unlinkAbg", "unlinkMax", ] # NOTE: used `float` as files_sec is a float number, doesn't really harm other stats line_dict = dict(zip(TYPES, map(float, line.split()))) # if you need partial-only line_dict - use list splitting, eg: line_dict = dict(zip(TYPES[20:22], map(float, line.split()[20:22])))

github-actions bot reviewed Jul 31, 2023

View reviewed changes

fs_mark/fs_mark.c Outdated Show resolved Hide resolved

adamdebek force-pushed the adamdebek/fs_mark branch 2 times, most recently from 885f77e to f63355e Compare July 31, 2023 12:24

mateusz-bloch reviewed Jul 31, 2023

View reviewed changes

adamdebek force-pushed the adamdebek/fs_mark branch 3 times, most recently from 9755602 to 385db8f Compare August 2, 2023 14:57

adamdebek force-pushed the adamdebek/fs_mark branch 13 times, most recently from 1a5c59e to c0ef729 Compare August 29, 2023 16:26

adamdebek force-pushed the adamdebek/fs_mark branch from c0ef729 to 9acbc20 Compare September 4, 2023 10:58

adamdebek force-pushed the adamdebek/fs_mark branch 2 times, most recently from 666d7b6 to 83b4faf Compare September 11, 2023 15:17

adamdebek force-pushed the adamdebek/fs_mark branch 4 times, most recently from e2cd77f to 377d622 Compare September 14, 2023 16:48

adamdebek force-pushed the adamdebek/fs_mark branch 2 times, most recently from c7715b6 to b700069 Compare October 6, 2023 08:26

adamdebek force-pushed the adamdebek/fs_mark branch 5 times, most recently from 20b14c8 to 9c72080 Compare December 1, 2023 10:42

adamdebek marked this pull request as draft December 5, 2023 15:14

adamdebek force-pushed the adamdebek/fs_mark branch 4 times, most recently from cef2eb5 to 599365e Compare December 6, 2023 09:40

adamdebek marked this pull request as ready for review December 6, 2023 09:42

adamdebek requested review from mateusz-bloch and damianloew December 6, 2023 09:43

adamdebek force-pushed the adamdebek/fs_mark branch 4 times, most recently from 9193843 to 5c61710 Compare December 6, 2023 15:20

mateusz-bloch reviewed Dec 12, 2023

View reviewed changes

fs_mark/fs_mark.py Outdated Show resolved Hide resolved

fs_mark/fs_mark.py Outdated Show resolved Hide resolved

damianloew requested changes Dec 20, 2023

View reviewed changes

adamdebek force-pushed the adamdebek/fs_mark branch from 5c61710 to f527874 Compare December 21, 2023 17:51

github-actions bot reviewed Dec 21, 2023

View reviewed changes

adamdebek force-pushed the adamdebek/fs_mark branch 2 times, most recently from 7271997 to 56501b5 Compare December 21, 2023 18:32

github-actions bot reviewed Dec 21, 2023

View reviewed changes

fs_mark/fs_mark.py Outdated Show resolved Hide resolved

adamdebek added 2 commits December 21, 2023 19:33

add fs_mark harness

2166d6b

JIRA: CI-307

trunner: add capability to assert sending long commands in ash

9d59598

JIRA: CI-307

adamdebek force-pushed the adamdebek/fs_mark branch from 56501b5 to 9d59598 Compare December 21, 2023 18:33

adamdebek requested a review from damianloew December 21, 2023 18:39

mateusz-bloch requested changes Apr 5, 2024

View reviewed changes

mateusz-bloch reviewed Apr 5, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add fs_mark harness #233

add fs_mark harness #233

adamdebek commented Jul 31, 2023

github-actions bot commented Sep 4, 2023 •

edited

Loading

damianloew Dec 20, 2023

adamdebek Dec 21, 2023

mateusz-bloch Apr 5, 2024

damianloew Dec 20, 2023

adamdebek Dec 21, 2023

damianloew Dec 20, 2023

damianloew Dec 20, 2023

damianloew Dec 20, 2023

adamdebek Dec 21, 2023

damianloew Dec 20, 2023

adamdebek Dec 21, 2023

github-actions bot Dec 21, 2023

mateusz-bloch Apr 5, 2024

mateusz-bloch Apr 5, 2024

mateusz-bloch Apr 5, 2024

mateusz-bloch Apr 5, 2024

mateusz-bloch Apr 5, 2024

mateusz-bloch Apr 5, 2024

mateusz-bloch Apr 5, 2024

mateusz-bloch Apr 5, 2024

mateusz-bloch Apr 5, 2024

mateusz-bloch Apr 5, 2024

mateusz-bloch Apr 5, 2024

nalajcie Apr 5, 2024



		def harness(dut: Dut, ctx: TestContext, result: TestResult):
		target = trunner.ctx.target.name

		return 0


		def harness(dut: Dut, ctx: TestContext, result: TestResult):

		from trunner.types import TestResult, Status


		def clean(dut, test_name, ctx: TestContext) -> int:

	def clean(dut, test_name, ctx: TestContext) -> int:
	def clean(dut: Dut, test_name: str, ctx: TestContext) -> int:

-                test_msg += "\n\n\tF_Use%: " + str(f_use)
-                test_msg += "\n\tCount: " + str(count)
-                test_msg += "\n\tSize: " + str(size)
-                test_msg += "\n\tFiles/sec: " + str(files_sec)
-                test_msg += "\n\tApp overhead: " + str(app_overhead) + "\n\t"
+		    test_msg += '\n\t'.join((
+		        f"F_Use%: {f_use}",
+		        f"Count: {count}",
+		        f"Size: {size}",
+		        f"Files/sec: {files_sec}",
+		        f"App overhead: {app_overhead}\n\t"
+		    ))

add fs_mark harness #233

Are you sure you want to change the base?

add fs_mark harness #233

Conversation

adamdebek commented Jul 31, 2023

Description

Motivation and Context

Types of changes

How Has This Been Tested?

Checklist:

Special treatment

github-actions bot commented Sep 4, 2023 • edited Loading

Unit Test Results

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot Dec 21, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Sep 4, 2023 •

edited

Loading