K arkadiusz/dirent test #294

KArkadiusz · 2023-11-14T11:42:10Z

Description

Motivation and Context

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

Already covered by automatic testing.
New test added: (add PR link here).
Tested by hand on: (list targets here).

Checklist:

My change requires a change to the documentation.
I have updated the documentation accordingly.
I have added tests to cover my changes.
All new and existing linter checks and tests passed.
My changes generate no new compilation warnings for any of the targets.

Special treatment

This PR needs additional PRs to work (list the PRs, preferably in merge-order).
I will merge this PR by myself when appropriate.

github-actions · 2023-11-14T11:55:04Z

Unit Test Results

6 591 tests +181 5 946 ✅ +170 33m 12s ⏱️ +25s
362 suites + 8 642 💤 + 8
1 files ± 0 3 ❌ + 3

For more details on these failures, see this check.

Results for commit ad63326. ± Comparison against base commit 5d4aee2.

♻️ This comment has been updated with latest results.

libc/dirent/readdir.c

libc/dirent/main.c

libc/dirent/closedir.c

libc/dirent/rewinddir.c

libc/dirent/readdir.c

libc/dirent/opendir.c

adamdebek

Some common things across the tests, which I point here:

Delete not used headers
Use macros instead wraper function to check errors, we want to see line number where error occurred
Use typed asserts instead of TEST_ASSERT_EQUAL
Use minimal needed permissions not 0777 everywhere
Declare variables at the start of block not in the middle
Some functions from your helper header are used only once so it misses the purpose of placing them in headers
Use curly braces with conditional statements (many are missing)
Many functions miss check for returned value

libc/dirent/closedir.c

libc/dirent/opendir.c

libc/dirent/readdir.c

libc/dirent/opendir.c

dirent: applied some suggestions

JIRA: CI-359

libc/Makefile

libc/dirent/dirent_helper_functions.h

adamdebek · 2024-04-10T11:13:10Z

libc/dirent/dirent_helper_functions.h

@@ -0,0 +1,19 @@
+#ifndef _DIRENT_HELPER_FUNCTIONS_H


I wonder if it shouldn't be placed in common header of whole libc.

I don't think they'll ever be needed anywhere else.

libc/dirent/readdir.c

adamdebek · 2024-04-10T16:02:09Z

libc/dirent/readdir.c

+}
+
+
+TEST(dirent_readdir, long_name_directory_check)


I see this testcase fails on some targets so it should be ignored for now and appropriate issue reported. See also that NAME_MAX can be variable depending on path and pathconf could be used to determine it, however pathconf is not implemented at this moment.

libc/dirent/readdir.c

KArkadiusz requested a review from damianloew November 14, 2023 11:42

damianloew requested a review from adamdebek November 14, 2023 12:01