Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

psh: add terminal control codes test #312

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maska989
Copy link
Contributor

@maska989 maska989 commented Jan 19, 2024

Description

JIRA: CI-397

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: armv7a7-imx6ull-evk.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

psh/test-control.py Outdated Show resolved Hide resolved
psh/test-control.py Outdated Show resolved Hide resolved
psh/test-control.py Show resolved Hide resolved
psh/test-control.py Outdated Show resolved Hide resolved
psh/test-control.py Outdated Show resolved Hide resolved
Comment on lines +49 to +55
@psh.run
def harness(p):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm considering whether to organize the tests in a uniform manner, for example, in relation to the CONTROL CODE CHEAT SHEET, and whether to expand the tests from basic ones that test a given control code, to tests that use several, and up to those that use as many as possible. It would be beneficial if the combinations reflected real-world scenarios. So, then you could also divide the tests into separate functions (?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is just to check that this control codes works, doesn't need to test them with full possibility use set.

psh/test-control.py Outdated Show resolved Hide resolved
psh/test-control.py Outdated Show resolved Hide resolved
psh/test-control.py Outdated Show resolved Hide resolved
psh/test.yaml Outdated Show resolved Hide resolved
@maska989 maska989 force-pushed the maska989/psh_control branch 2 times, most recently from d8ba5ca to 01345a4 Compare January 26, 2024 11:55
psh/test-control.py Outdated Show resolved Hide resolved
@maska989 maska989 force-pushed the maska989/psh_control branch 2 times, most recently from 0ef59b3 to c4c686e Compare January 30, 2024 13:54
@maska989 maska989 marked this pull request as ready for review January 30, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants