Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

network: add tcp test #326

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

network: add tcp test #326

wants to merge 1 commit into from

Conversation

adamdebek
Copy link
Contributor

JIRA: CI-343

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@adamdebek adamdebek marked this pull request as draft February 20, 2024 18:36
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 20, 2024 •
edited
Loading

Unit Test Results

7 471 tests   6 756 ✅  38m 19s ⏱️
  421 suites    715 💤
    1 files        0 ❌

Results for commit 56972fd.

♻️ This comment has been updated with latest results.

@adamdebek adamdebek force-pushed the adamdebek/CI-343 branch 5 times, most recently from eb1c8c9 to dc3c265 Compare February 21, 2024 10:41
mateusz-bloch

This comment was marked as resolved.

Sign in to view

@adamdebek adamdebek force-pushed the adamdebek/CI-343 branch 11 times, most recently from 52d08d7 to 9616f35 Compare February 21, 2024 13:44
@adamdebek adamdebek force-pushed the adamdebek/CI-343 branch 10 times, most recently from 4aac9fa to 146a39e Compare February 27, 2024 17:02
@adamdebek adamdebek force-pushed the adamdebek/CI-343 branch 2 times, most recently from cceda4f to 9ff1e37 Compare April 24, 2024 16:35
github-actions[bot]
github-actions bot reviewed Jun 7, 2024
View reviewed changes
network/tcp-harness.py Outdated Show resolved Hide resolved
network/test-tcp.c Outdated Show resolved Hide resolved
@adamdebek adamdebek force-pushed the adamdebek/CI-343 branch 19 times, most recently from 73fe65a to 372debc Compare June 17, 2024 15:07
@adamdebek adamdebek force-pushed the adamdebek/CI-343 branch 3 times, most recently from 62e5268 to 9f08299 Compare June 28, 2024 19:42
@adamdebek
add tcp test
56972fd 
JIRA: CI-343
@adamdebek adamdebek marked this pull request as ready for review July 1, 2024 15:37
@damianloew damianloew requested a review from Darchiv July 5, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateusz-bloch mateusz-bloch mateusz-bloch left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

@Darchiv Darchiv Awaiting requested review from Darchiv

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamdebek @mateusz-bloch