libc: re-enable tests for floats #367
Open
+2,121
−2,196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test Results7 949 tests +16 7 391 ✅ +176 40m 15s ⏱️ +2s Results for commit 79f4a66. ± Comparison against base commit c510830. This pull request removes 729 and adds 745 tests. Note that renamed tests count towards both.This pull request removes 137 skipped tests and adds 33 skipped tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
damianloew
force-pushed
the
jmaksymowicz/RTOS-868
branch
from
1bd7f6d
to
c4f4d0e
Compare
Re-enable tests related to issues #703, #704, #634, #652, #681 JIRA: RTOS-868
jmaksymowicz
force-pushed
the
jmaksymowicz/RTOS-868
branch
from
c4f4d0e
to
b44e0dd
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| buff[i - 1] = i - 1; | ||
| } | ||
|
|
||
| /* Bypass \n bcause of issue: https://github.com/phoenix-rtos/phoenix-rtos-project/issues/679 */ |
There was a problem hiding this comment.
[codespell] reported by reviewdog 🐶
bcause ==> because
Put tests for integer conversion specifiers into `test-libc-scanf-basic` and the remaining tests into `test-libc-scanf_advanced`. Split was made to make the tests fit on targets where RAM is limited (e.g. stm32l4x6). JIRA: RTOS-868
jmaksymowicz
force-pushed
the
jmaksymowicz/RTOS-868
branch
from
151146d
to
79f4a66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-enable tests related to issues #703, #704, #634, #652, #681
These issues were fixed by phoenix-rtos/libphoenix#370
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment