Merge pull request #40 from photogabble/patch/v1.1.0/#39

BUGFIX: encode link title html entities
photogabble · May 3, 2024 · 1b1e4cb · 1b1e4cb
2 parents e603481 + 399b55f
commit 1b1e4cb
Show file tree

Hide file tree

Showing 7 changed files with 216 additions and 49 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+- Bugfix HTML encode link titles (#40)
 - Bugfix broken dead-links lookup due to typo (#38)
 - Bugfix do not render embeds if the page linked doesn't exist (#35)
 - Bugfix do not parse links in pages excluded from collections (#30)

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -49,7 +49,8 @@
   },
   "dependencies": {
     "chalk": "^4.1.1",
-    "markdown-it": "^13.0.1"
+    "entities": "^4.5.0",
+    "markdown-it": "^14.1.0"
   },
   "devDependencies": {
     "@11ty/eleventy": "^2.0.0",

diff --git a/src/markdown-ext.js b/src/markdown-ext.js
@@ -1,4 +1,4 @@
-const chalk = require('chalk');
+const entities = require("entities");
 
 /**
  * This rule will be looped through an inline token by markdown-it.
@@ -70,7 +70,7 @@ const wikilinkRenderRule = (wikilinkParser, compiledEmbeds, opts) => (tokens, id
 
   const anchor = {
     href: link.href,
-    text: link.title ?? link.name,
+    text: entities.encodeHTML(link.title ?? link.name),
   };
 
   if (link.anchor) {