Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed producer fallback in sandbox mode #282

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ramunasd
Copy link
Member

Fallback lacks method setContentType

@videlalvaro
Copy link
Collaborator

The tests are not passing.

Also, wouldn't this break BC?

@ramunasd
Copy link
Member Author

ramunasd commented Jul 6, 2015

Travis had temporary issue, now it's passing all tests.
About BC - if someone has written it's own producer that implements ProducerInterface - then yes, it BC.

@videlalvaro
Copy link
Collaborator

Sorry to comment so late, but I think this method and setDeliveryMode should be added here as well? Why not have them in the ProducerInterface as well?

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@ramunasd
Copy link
Member Author

@mihaileu this is the old one, but maybe still actual?

@mihaileu mihaileu added this to the 3.0 milestone Mar 17, 2021
@mihaileu
Copy link
Collaborator

As is a BC, it should be added in the next major version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants