Add support for setting $_SERVER['HTTPS'] var #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I replaced my php-fpm with that project for Laravel and use a NGINX proxy in front of it.
With PHP FPM i had a scheme detection which was set the HTTPS var on FastCGI for forcing Laravel to generate https urls.
After I run that with php-ppm i noticed that the X-Forwarded-Proto is not working, as i looked in the code i saw that this var is not parsed and no HTTPS var is set on $_SERVER array.
So that pull request to fix that.