Adjust logic targeting inaccessible nodes #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loosen parent check from Class_ to ClassLike, to include Traits, Interfaces, and Enums. Remove protected nodes, regardless if the class is final or not. Adjust test
szepeviktor
reviewed
Apr 12, 2023
Comment on lines
+247
to
+251
| if (!$this->includeInaccessibleClassNodes | ||
| && $parent instanceof Class_ | ||
| && ($node instanceof ClassMethod || $node instanceof ClassConst || $node instanceof Property) | ||
| && ($node->isPrivate() || $node->isProtected()) | ||
| ) { |
There was a problem hiding this comment.
Suggested change
| if (!$this->includeInaccessibleClassNodes | |
| && $parent instanceof Class_ | |
| && ($node instanceof ClassMethod || $node instanceof ClassConst || $node instanceof Property) | |
| && ($node->isPrivate() || $node->isProtected()) | |
| ) { | |
| if ( | |
| !$this->includeInaccessibleClassNodes | |
| && $parent instanceof Class_ | |
| && ($node instanceof ClassMethod || $node instanceof ClassConst || $node instanceof Property) | |
| && ($node->isPrivate() || $node->isProtected()) | |
| ) { |
|
Thank you for your contribution! I've given up on WC and disabled this feature, thus including inaccessible things. Could WC stubs be executed with this PR? |
What is someone extends a WC class with protected methods? Will this introduce static analysis errors? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Class_toClassLiketo includeTraits,Interfaces, andEnums.Reason
Unfortunately, sometimes developers define protected or private methods in interfaces or traits.
I'm looking at you WooCommerce:
The missing abstract method (
get_values_for_total) is defined in a trait:https://github.com/woocommerce/woocommerce/blob/c4a7e9a11b62e9f62fd507f5a0c8ae09740619a0/plugins/woocommerce/includes/traits/trait-wc-item-totals.php#L32