Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stubs for new WordPress releases #162

Closed
wants to merge 33 commits into from
Closed

Add stubs for new WordPress releases #162

wants to merge 33 commits into from

Conversation

swissspidy
Copy link
Contributor

Adds 6.5 to release-latest-versions.sh

/**
* Validates the redirect URL protocol scheme. The protocol can be anything except http and javascript.
*
* @since 6.3.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There must be something wrong here ...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit says Generate stubs for WordPress 6.2.3

@swissspidy Please advise, you are The WordPress Superhero.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@swissspidy Please says something. Is this a core error?

@szepeviktor
Copy link
Member

szepeviktor commented Apr 3, 2024

not all WP releases are released here!
Where are these old ones coming from???

@szepeviktor
Copy link
Member

szepeviktor commented Apr 3, 2024

There must have been a security incident in January.

@swissspidy
Copy link
Contributor Author

Yes there were a few security releases recently. For example 6.3.2 was released in October, see https://wordpress.org/documentation/wordpress-version/version-6-3-2/ and 6.3.3 in January, see https://wordpress.org/documentation/wordpress-version/version-6-3-3/

@szepeviktor
Copy link
Member

It is not possible to push tags in a PR 😢

@swissspidy
Copy link
Contributor Author

Yeah I was just about to say. I think you need to run the script on the main branch yourself because of all the tags. Or give me access 👿 😄

@IanDelMar
Copy link
Contributor

The functionMap.php needs some changes.

@@ -4552,7 +4560,8 @@ protected function get_items_per_page($option, $default_value = 20)
*
* @since 3.1.0
*
* @param string $which
* @param string $which The location of the pagination: Either 'top' or 'bottom'.
* @phpstan-param 'top'|'bottom' $which
* @phpstan-param "top"|"bottom" $which
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs change in functionMap.php

@@ -4692,7 +4701,8 @@ protected function get_table_classes()
* Generates the table navigation above or below the table
*
* @since 3.1.0
* @param string $which
* @param string $which The location of the navigation: Either 'top' or 'bottom'.
* @phpstan-param 'top'|'bottom' $which
* @phpstan-param "top"|"bottom" $which
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs change in functionMap.php

* time: string|false,
* type: string,
* files: array|false,
* }>
* @phpstan-return false|array<string, array{name: string, perms: string, permsn: string, owner: string|false, size: int|string|false, lastmodunix: int|string|false, lastmod: string|false, time: string|false, type: 'f'|'d'|'l', group?: string|false, number?: int|string|false, files?: array|false}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs check

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to release stubs with bugs.

@@ -62545,32 +63877,202 @@ public function __construct()
* @param array[][] $fonts Optional. The font-families and their font variations.
* See {@see wp_print_font_faces()} for the supported fields.
* Default empty array.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why has the @phpstan-param disappeared?

@herndlm
Copy link
Contributor

herndlm commented Apr 3, 2024

what is going on here, why are there so many (old) commits :D

@swissspidy
Copy link
Contributor Author

@herndlm Because there were many WordPress releases :)

@herndlm
Copy link
Contributor

herndlm commented Apr 3, 2024

but we can only ever update the stubs and create a tag for one at a time AFAIK

@herndlm
Copy link
Contributor

herndlm commented Apr 3, 2024

and going to an old one would basically revert stuff, which might look weird. I guess now I understand what Viktor meant with adding tags in a branch / PR hmm.

ok, but makes sense. got it now :)

@szepeviktor
Copy link
Member

szepeviktor commented Apr 3, 2024

Going to release everything up to 6.5.0 manually.
I leave core phpstan tags vs. our phpstan tags up to You guys.

@szepeviktor szepeviktor closed this Apr 3, 2024
@swissspidy swissspidy deleted the chore/update-stubs branch April 3, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants