Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop bugging Harald #161

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Stop bugging Harald #161

merged 1 commit into from
Oct 24, 2024

Conversation

cmb69
Copy link
Member

@cmb69 cmb69 commented Oct 5, 2024

See php/doc-en#3836.


Likely fails for some translations. Let's see.

Copy link
Member

@kamil-tekiela kamil-tekiela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update all translations first?

@cmb69
Copy link
Member Author

cmb69 commented Oct 5, 2024

Should we update all translations first?

I wouldn't know how to do that (except for German). Maybe we should just wait some days or weeks, and merge then.

@Girgias
Copy link
Member

Girgias commented Oct 5, 2024

Should we update all translations first?

I wouldn't know how to do that (except for German). Maybe we should just wait some days or weeks, and merge then.

I thinking waiting for a couple of days and restarting the CI is a better idea. :)

@cmb69
Copy link
Member Author

cmb69 commented Oct 24, 2024

Just triggered CI again; most translations fail because of the MongoDB set to book conversion. I don't think adding this on top would be an issue.

@cmb69 cmb69 merged commit 33ef031 into php:master Oct 24, 2024
1 of 12 checks passed
@cmb69 cmb69 deleted the cmb/no-harald branch October 24, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants