Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Updated paragraph on initialization of static variables (GH-3827)
* Updated paragraph on initialization of static variables Updated information about restrictions on initialization of static variables to comply with PHP 8.3 * Removed confusing note in static variables section As of PHP 8.3, static declarations are resolved not only at compile time * Removed confusing note in static variables section As of PHP 8.3, static declarations are resolved not only at compile time. Closes GH-3701.
- Loading branch information
b6915fd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This uses personalization in the text.
We really need a script to flag this and fail CI.
b6915fd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, going to fix right away.
PS: 18 occurrences of "you" on that page. On three of "your".
b6915fd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checked, across all doc-en there are 3260~ mentions of "you". So getting rid of all of them is going to be tedious.
It is more about not adding more to the list
b6915fd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, but a simple script looking for "you" will only find the most obvious issues (still, better than nothing, though). I should have caught that in the first place.