Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UTCDateTime supports Int64, deprecates string and float #3794

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

The <parameter>milliseconds</parameter> argument now accepts a
<classname>MongoDB\BSON\Int64</classname> object (for compatibility on
32-bit platforms). Specifying a <type>string</type> or
<type>float</type> is deprecated.
Copy link
Member Author

@jmikola jmikola Sep 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecation for float was technically missed in 1.20, but I think it makes more sense to document these together. Both types will be removed in 2.0 (PHPC-2444, PHPC-2459).

Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the XML changes.

@jmikola jmikola merged commit c856472 into php:master Sep 26, 2024
2 checks passed
@jmikola jmikola deleted the phpc-2443-2458 branch September 26, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants