Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing new classes to migration guides #3832

Merged
merged 1 commit into from
Oct 5, 2024

Conversation

cmb69
Copy link
Member

@cmb69 cmb69 commented Oct 4, 2024

While these are already documented in the incompatible changes section regarding the resource to object conversions, they should also be listed explicitly as new classes.


Note that I used to verbose <itemizedlist> markup for consistency, although a <simplelist> seems more appropriate.

While these are already documented in the incompatible changes section
regarding the resource to object conversions, they should also be
listed explicitly as new classes.
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I feel those might also need to be added for 8.2/8.3

@cmb69
Copy link
Member Author

cmb69 commented Oct 5, 2024

I didn't find any for 8.2 or 8.3 (checked the incompatible sections of the migration guide).

@Girgias Girgias merged commit 0b48d83 into php:master Oct 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants