Depersonalize variables.xml #3835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least we remove the grossest style guideline violations. This still partly reads like a tutorial, though. And the page is long.
|
cc @Girgias |
|
Just the whitespace issues. |
| and pass this along. i.e. | ||
| name in the browser unless the path or domain is different. So, | ||
| for a shopping cart application a counter may be kept, | ||
| and passed along. I.e. |
There was a problem hiding this comment.
What does I.e mean here? Is this meant to be a new sentence? The correct usage of i.e. ("id est") is to interrupt a sentence with further explanation. It doesn't apply here at all.
There was a problem hiding this comment.
Yeah, could be a comma instead of a full stop. But have a look at the document; it is in thorough need of an overhaul anyway.
There was a problem hiding this comment.
Alright, let me see if I can come up with some PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least we remove the grossest style guideline violations. This still partly reads like a tutorial, though. And the page is long.