Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] do not parse version config node #1063

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Conversation

jaapio
Copy link
Member

@jaapio jaapio commented Sep 4, 2024

symfony is trying to normalize the xml input using
some logic. However in our case we want to fetch the raw value for version. But this is not possible. therefor an escape system is added by adding '.

fixes #1057

@jaapio jaapio requested a review from linawolf September 4, 2024 18:22
@jaapio jaapio marked this pull request as draft September 4, 2024 18:24
@jaapio jaapio marked this pull request as ready for review September 4, 2024 18:45
symfony is trying to normalize the xml input using
some logic. However in our case we want to fetch the raw value for version. But this is not possible. therefor an escape system is added by adding `'`.
@jaapio jaapio merged commit 28819a4 into main Sep 6, 2024
40 checks passed
@jaapio jaapio deleted the fix/1057-version-number branch September 6, 2024 17:00
@phpdoc-bot
Copy link

💔 All backports failed

Status Branch Result
1.x Cherrypick failed because the selected commit was a merge commit. Please try again by specifying the parent with the mainline argument:

backport --mainline

or:

backport --mainline

Or refer to the git documentation for more information: https://git-scm.com/docs/git-cherry-pick#Documentation/git-cherry-pick.txt---mainlineparent-number|

Manual backport

To create the backport manually run:

backport --pr 1063

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: XML "version" root projectnode config interprets version numbers not as strings
3 participants